Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(job-scheduler): return undefined in getJobScheduler when it does not exist #3065

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix(job-scheduler): return undefined in getJobScheduler when it does not exist #3065

wants to merge 1 commit into from
+14 −2

Conversation

roggervalf
Copy link
Collaborator

@roggervalf roggervalf commented Feb 8, 2025 •
edited
Loading

Why

  1. Why is this change necessary? If job scheduler does not exist, getJobScheduler method tries to split the id because of the old format of repeatable jobs. But as old format requires to have this id separated by :, we can also validate that the id does not contains :. Take in count that transformation of this data is being used for getJobSchedulers too.

How

  1. How did you implement this? Change retuned type to undefined and when validating old format, make sure id/ key contains : before trying to transform it to old repeatable format

Additional Notes (Optional)

fixes #3062

@roggervalf roggervalf changed the title fix(job-scheduler): return undefined in getJobScheduler when it does … fix(job-scheduler): return undefined in getJobScheduler when it does not exist Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Should Queue.getJobScheduler() return null/undefined when a job scheduler does not exist
1 participant
@roggervalf