Skip to content

Commit bf87c16

Browse files
authored
Upgrade to angular 13 (#49)
* manually replace tslint with eslint - used the eslintrc from the base project - removed all trace of tslint and uninstalled codelyzer as well * upgrade to angular 13 and bump version number
1 parent f52ca66 commit bf87c16

File tree

16 files changed

+3061
-5600
lines changed

16 files changed

+3061
-5600
lines changed

.eslintignore

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,2 @@
1+
node_modules
2+
dist

.eslintrc

Lines changed: 37 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,37 @@
1+
{
2+
"root": true,
3+
"parser": "@typescript-eslint/parser",
4+
"plugins": ["@typescript-eslint"],
5+
"ignorePatterns": ["*.generated.ts"],
6+
"extends": [
7+
"eslint:recommended",
8+
"plugin:@typescript-eslint/eslint-recommended",
9+
"plugin:@typescript-eslint/recommended"
10+
],
11+
"rules": {
12+
// in addition to the recommended rules, add the following:
13+
"eqeqeq": ["error", "always", { "null": "ignore" }],
14+
"no-eval": "error",
15+
"no-console": ["error", { "allow": ["info", "table", "warn", "error"] }],
16+
"curly": "error",
17+
"no-bitwise": "error",
18+
"no-lone-blocks": "error",
19+
"no-lonely-if": "error",
20+
"no-return-assign": "error",
21+
"max-depth": "error",
22+
23+
// Downgrade the rules from erros to warning
24+
// Those are things that generally aren't nice, but there's too much of them in the code base
25+
// to eliminate all at once.
26+
"no-unused-vars": "warn",
27+
"@typescript-eslint/no-explicit-any": "warn",
28+
"@typescript-eslint/no-unused-vars": "warn",
29+
"@typescript-eslint/no-this-alias": "warn",
30+
"@typescript-eslint/no-var-requires": "warn",
31+
32+
// We turn warnings off for what we deem to be ok
33+
"@typescript-eslint/no-inferrable-types": "off", // type annotations can be useful for the reader
34+
"@typescript-eslint/no-empty-function": "off", // there's a lot of empty ngOnInit blocks, and we don't plan to get rid of those
35+
"no-empty-function": "off"
36+
}
37+
}

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,7 @@ speed-measure-plugin*.json
4040
.history/*
4141

4242
# misc
43+
/.angular/cache
4344
/.sass-cache
4445
/connect.lock
4546
/coverage

angular.json

Lines changed: 0 additions & 26 deletions
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,6 @@
4848
"optimization": true,
4949
"outputHashing": "all",
5050
"sourceMap": false,
51-
"extractCss": true,
5251
"namedChunks": false,
5352
"extractLicenses": true,
5453
"vendorChunk": false,
@@ -102,19 +101,6 @@
102101
"scripts": []
103102
}
104103
},
105-
"lint": {
106-
"builder": "@angular-devkit/build-angular:tslint",
107-
"options": {
108-
"tsConfig": [
109-
"tsconfig.app.json",
110-
"tsconfig.spec.json",
111-
"e2e/tsconfig.json"
112-
],
113-
"exclude": [
114-
"**/node_modules/**"
115-
]
116-
}
117-
},
118104
"e2e": {
119105
"builder": "@angular-devkit/build-angular:protractor",
120106
"options": {
@@ -154,18 +140,6 @@
154140
"tsConfig": "projects/angular-keyboard/tsconfig.spec.json",
155141
"karmaConfig": "projects/angular-keyboard/karma.conf.js"
156142
}
157-
},
158-
"lint": {
159-
"builder": "@angular-devkit/build-angular:tslint",
160-
"options": {
161-
"tsConfig": [
162-
"projects/angular-keyboard/tsconfig.lib.json",
163-
"projects/angular-keyboard/tsconfig.spec.json"
164-
],
165-
"exclude": [
166-
"**/node_modules/**"
167-
]
168-
}
169143
}
170144
}
171145
}},

0 commit comments

Comments
 (0)