Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gem referral animation repeats every 40s after a true referral 0.8.13 #1238

Open
metalaureate opened this issue Dec 12, 2024 · 0 comments
Open
Assignees

Comments

@metalaureate
Copy link
Collaborator

Describe the bug

After receiving 5000 gems for a true referral, the 5000 gem animation in the side-panel continues to trigger every 40s (no gems are rewarded).

@metalaureate metalaureate changed the title Gem animation referral repeats every 40s after a true referral Gem animation referral repeats every 40s after a true referral 0.8.13 Dec 12, 2024
@metalaureate metalaureate changed the title Gem animation referral repeats every 40s after a true referral 0.8.13 Gem referral animation repeats every 40s after a true referral 0.8.13 Dec 12, 2024
@shanimal08 shanimal08 self-assigned this Dec 12, 2024
@shanimal08 shanimal08 moved this to In Progress in Universe V1 tasks Dec 12, 2024
brianp pushed a commit that referenced this issue Dec 12, 2024
Description
---

- cleaned up animation timeouts (couldn't repro the original issue but
there was an issue of the animaions not actually going away which was
reporoducable every time)
- cleaned up the `useAirdropUserPointsListener` listener and how the
zustand store was updated there:
- biggest one being the check against the count from the payload vs the
store - made sure to only update the store after
- added triggers for the animations for very BASIC testing in the admin
ui (not that helpful since it's not directly related to the points)

Motivation and Context
---
- resolves an issue picked up when checking
#1238, but should also
hopefully resolve that issue. couldn't reproduce but it's all related to
the listener and the timeouts being weird 😬

How Has This Been Tested?
---

- locally, pointing to airdrop dev BE and adding the referrals (and
target for the extra animation!) manually to trigger the points
listener:


https://github.com/user-attachments/assets/db2b2049-d9f1-4398-a6f5-e1296430a56a



What process can a PR reviewer use to test or verify this change?
---

little bit tough if you don't have access to the BE (dev!) admin for
testing, but you can also just make sure your local dev build is
pointing to airdrop dev, then on a separate dev build use your referral
code, and wait for the points to test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

No branches or pull requests

2 participants