test: fix cucumber wallet fii status access violation #6695
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hansieodendaal
changed the title
- Added a unit test to compare the ffi lib with the ffi import function signatures. - Fixed all ffi import function signatures that did not match.
hansieodendaal
force-pushed
the
ho_ffi_import
branch
from
5c1e431 to
0e03a1a
Compare
hansieodendaal
force-pushed
the
ho_ffi_import
branch
from
0e03a1a to
5e41b63
Compare
Test Results (CI) 3 files 126 suites 10m 54s ⏱️ Results for commit 5e41b63. |
Test Results (Integration tests) 2 files 10 suites 15m 14s ⏱️ For more details on these failures, see this check. Results for commit 5e41b63. |
SWvheerden
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix cucumber ffi import
Note: Added better logging for cucumber merge mining process, but
Scenario: Simple Merge Miningis still broken,Motivation and Context
There were memory access errors.
How Has This Been Tested?
Scenario: As a client I want to be able to restore my ffi wallet from seed wordsnow passWhat process can a PR reviewer use to test or verify this change?
Run cucumber
Code review
Breaking Changes