Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enables lockfile workflow with sbt-dependency-lock #153

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Enables lockfile workflow with sbt-dependency-lock #153

wants to merge 2 commits into from

Conversation

colindean
Copy link
Collaborator

Caveats of this:

  1. Crossbuilds may not be supported, impacting Release builds for newer versions of Scala and Spark #84.
  2. The hash used is SHA1, which is deprecated including by NIST. Some work is in draft PRs for introducing a new version of the lockfile that may enable SHA256 or other hash algorithms.

Fixes #129

@colindean
Enables lockfile workflow with sbt-dependency-lock
aa1f1f7 
Caveats of this:

1. [Crossbuilds may not be supported][crossbuilds], impacting #84.
2. The hash used is SHA1, which is deprecated including by [NIST][nist].
   Some work is in draft PRs for introducing a new version of the
   lockfile that may enable SHA256 or other hash algorithms.

Fixes #129

[crossbuilds]: stringbean/sbt-dependency-lock#13
[nist]: https://www.nist.gov/news-events/news/2022/12/nist-retires-sha-1-cryptographic-algorithm
@colindean colindean requested a review from c-horn as a code owner April 3, 2023 18:06
@colindean colindean requested a review from a team as a code owner April 11, 2024 16:07
@colindean colindean requested a review from abs428 April 11, 2024 16:07
@colindean
Copy link
Collaborator Author

This will have to be relocked to work, so I'm taking it back to draft until I have time to take that step locally.

@colindean colindean marked this pull request as draft April 11, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samratmitra-0812 samratmitra-0812 samratmitra-0812 approved these changes

@c-horn c-horn Awaiting requested review from c-horn c-horn is a code owner

@abs428 abs428 Awaiting requested review from abs428 abs428 is a code owner automatically assigned from target/data-validator-members

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Lock dependencies with sbt-dependency-lock
2 participants
@colindean @samratmitra-0812