Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CI workflow for checking submodules #6984

Open
locker opened this issue Mar 31, 2022 · 1 comment
Open

Add CI workflow for checking submodules #6984

locker opened this issue Mar 31, 2022 · 1 comment

Comments

@locker
Copy link
Member

locker commented Mar 31, 2022

With private forks and multiple submodules, it's quite easy to slip up and merge a commit that updates a submodule to a commit from someone's private fork. We need a workflow that checks that all submodules point to commits from original repositories, not from forks.

Note: There's a similar ticket for checkpatch tarantool/checkpatch#9. However, checking submodules should probably be done in a separate workflow so that we can differentiate a malformed patch case from the situation when the submodule is intentionally set to a private fork, because the submodule commit hasn't been merged yet (i.e. it's okay to review the pull request, but it shouldn't be merged until the submodule repository is updated; this is especially actual for the enterprise repository, where submodule updates happen regularly). It still makes sense to require a separate tag in the commit message, indicating that a submodule update is intentional though.

Note: We have a script that implements a similar check, but it doesn't check all submodules so it should be fixed before it can be used in the new workflow.

@locker locker added qa Issues related to tests or testing subsystem infrastructure and removed qa Issues related to tests or testing subsystem labels Mar 31, 2022
@kyukhin kyukhin added the teamQ label Apr 8, 2022
@NickVolynkin
Copy link
Contributor

That's a good idea!

@TarantoolBot TarantoolBot removed the teamX label Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants