forked from fl00r/go-tarantool-1.6
-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Consider generation of API documentation from sources #123
Labels
code health
Improve code readability, simplify maintenance and so on
Comments
Totktonada
added
teamE
code health
Improve code readability, simplify maintenance and so on
raw idea
labels
Dec 13, 2021
This was referenced Mar 31, 2022
Merged
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
Add GoDoc bagde generated by [1] with link to HTML documentation, badge for GH Actions, badges for Telegram channel, StackOverflow topic and Github Discussions. Part of #123 1. https://pkg.go.dev/badge/
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
- replace "tarantool" with "Tarantool" - replace "lua" with "Lua" - remove apostrophes in comments - fixed typos - remove unneeded empty lines that break documentation generation - add a version where new methods or packages were added - remove apostrophes in comment for Connection - add dots to the end of sentences - start sentences with capitalized letter Part of #123
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
- make example executable - add description with steps how to run example manually Part of #123
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
- make example executable with adding reference output - add description of steps how to run example manually - update comments for methods in queue.go See more about running examples in "Testable Examples in Go" [1] and testing package documentation [2]. Part of #123 1. https://go.dev/blog/examples 2. https://pkg.go.dev/testing#hdr-Examples
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
README contains an example like already exist in a example_test.go, so example in a README was removed and example in tests has been updated: - single example splitted to multiple examples for Connection methods - added new examples for Ping(), Insert(), Delete(), Replace(), Update(), Call17(), Eval() and Connect() Part of #123
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
Previously each example created a connection and processed error. To make examples more compact and clear for documentation reader patch handles connection error in example_connect() used in examples and panics in case of error. Part of #123
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
Make example executable by adding reference output to the comments. Part of #123
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
- split schema example to multiple examples - make examples executable Part of #123
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
Commented out code with old way to register types has been removed. Part of #123
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
Go 1.3 mentioned in installation section was EOLed many years ago. No sense to describe it's installation. Go 1.3 replaced with Go 1.13. Go 1.13 is outdated too and unsupported, but we run tests with it in Github Actions so it is a guarantee that everything will works with it. Part of #123
ligurio
added a commit
that referenced
this issue
Apr 14, 2022
There is a guide made by Github with recommendations how to make project healthy for contributors [1]. One of them is a contributing guide with steps for new contributors. Knowledge about running tests in a project is not needed to all people who will read our README, so I moved this section to contributing guide. Part of #123 1. https://docs.github.com/en/communities/setting-up-your-project-for-healthy-contributions
ligurio
added a commit
that referenced
this issue
Apr 20, 2022
ligurio
added a commit
that referenced
this issue
Apr 20, 2022
We have a walking through example in a README and examples in GoDoc. Seems it is more than enough. Part of #123
ligurio
added a commit
that referenced
this issue
Apr 20, 2022
- add a section 'Documentation' and two subsections: - with 'Walking Through' example - with API documentation - fix code formatting in 'Walking-Through' example - remove description of Opts settings in description for 'Walking-Through' example - remove a program name in description for 'Walking-Through' example - update English grammar in description for 'Walking Through' example Part of #123
ligurio
added a commit
that referenced
this issue
Apr 20, 2022
ligurio
added a commit
that referenced
this issue
Apr 20, 2022
1 task
ligurio
added a commit
that referenced
this issue
Apr 21, 2022
Merged
ligurio
added a commit
that referenced
this issue
Apr 21, 2022
ligurio
added a commit
to tarantool/doc
that referenced
this issue
May 6, 2022
Follows up tarantool/go-tarantool#142 Follows up tarantool/go-tarantool#123
ligurio
added a commit
to tarantool/doc
that referenced
this issue
May 11, 2022
Follows up tarantool/go-tarantool#142 Follows up tarantool/go-tarantool#123
ligurio
added a commit
to tarantool/doc
that referenced
this issue
May 11, 2022
Follows up tarantool/go-tarantool#142 Follows up tarantool/go-tarantool#123
patiencedaur
pushed a commit
to tarantool/doc
that referenced
this issue
May 16, 2022
Follows up tarantool/go-tarantool#142 Follows up tarantool/go-tarantool#123
patiencedaur
added a commit
to tarantool/doc
that referenced
this issue
May 16, 2022
…nalysis) (#2860) * Update go-tarantool in comparison table Follows up tarantool/go-tarantool#142 Follows up tarantool/go-tarantool#123 * Update translation Co-authored-by: Patience Daur <[email protected]>
oleg-jukovec
added a commit
that referenced
this issue
Jun 1, 2022
Overview This release adds a number of features and updates documentation. Breaking changes There are no breaking changes in the release. New features Coveralls support (#149). Reusable testing workflow (integration testing with latest Tarantool) (#123). Simple CI based on GitHub actions (#114). Support UUID type in msgpack (#90). Go modules support (#91). queue-utube handling (#85). Master discovery (#113). SQL support (#62). Handle everything with `go test` (#115). Update API documentation: comments and examples (#123). Bugfixes Reset buffer if its average use size smaller than quater of capacity (#95). Fix queue tests (#107). Make test case consistent with comments (#105).
oleg-jukovec
added a commit
that referenced
this issue
Jun 1, 2022
Overview This release adds a number of features and updates documentation. Breaking changes There are no breaking changes in the release. New features Coveralls support (#149). Reusable testing workflow (integration testing with latest Tarantool) (#123). Simple CI based on GitHub actions (#114). Support UUID type in msgpack (#90). Go modules support (#91). queue-utube handling (#85). Master discovery (#113). SQL support (#62). Handle everything with `go test` (#115). Update API documentation: comments and examples (#123). Bugfixes Reset buffer if its average use size smaller than quater of capacity (#95). Fix queue tests (#107). Make test case consistent with comments (#105).
oleg-jukovec
added a commit
that referenced
this issue
Jun 1, 2022
Overview This release adds a number of features and updates documentation. Breaking changes There are no breaking changes in the release. New features Coveralls support (#149). Reusable testing workflow (integration testing with latest Tarantool) (#123). Simple CI based on GitHub actions (#114). Support UUID type in msgpack (#90). Go modules support (#91). queue-utube handling (#85). Master discovery (#113). SQL support (#62). Handle everything with `go test` (#115). Update API documentation: comments and examples (#123). Bugfixes Reset buffer if its average use size smaller than quater of capacity (#95). Fix queue tests (#107). Make test case consistent with comments (#105).
Merged
oleg-jukovec
added a commit
that referenced
this issue
Jun 1, 2022
Overview This release adds a number of features and updates documentation. Breaking changes There are no breaking changes in the release. New features Coveralls support (#149). Reusable testing workflow (integration testing with latest Tarantool) (#112). Simple CI based on GitHub actions (#114). Support UUID type in msgpack (#90). Go modules support (#91). queue-utube handling (#85). Master discovery (#113). SQL support (#62). Handle everything with `go test` (#115). Update API documentation: comments and examples (#123). Bugfixes Reset buffer if its average use size smaller than quater of capacity (#95). Fix queue tests (#107). Make test case consistent with comments (#105).
oleg-jukovec
added a commit
that referenced
this issue
Jun 2, 2022
Overview This release adds a number of features. Also it significantly improves testing, CI and documentation. Breaking changes There are no breaking changes in the release. New features Support UUID type in msgpack (#90). queue-utube handling (#85). Master discovery (#113). SQL support (#62). Bugfixes Reset buffer if its average use size smaller than quater of capacity (#95). Testing Coveralls support (#149). Reusable testing workflow (integration testing with latest Tarantool) (#112). Simple CI based on GitHub actions (#114). Handle everything with `go test` (#115). Fix queue tests (#107). Make test case consistent with comments (#105). Other Go modules support (#91). Update API documentation: comments and examples (#123).
oleg-jukovec
added a commit
that referenced
this issue
Jun 2, 2022
Overview This release adds a number of features. Also it significantly improves testing, CI and documentation. Breaking changes There are no breaking changes in the release. New features Support UUID type in msgpack (#90). queue-utube handling (#85). Master discovery (#113). SQL support (#62). Bugfixes Reset buffer if its average use size smaller than quater of capacity (#95). Testing Coveralls support (#149). Reusable testing workflow (integration testing with latest Tarantool) (#112). Simple CI based on GitHub actions (#114). Handle everything with `go test` (#115). Fix queue tests (#107). Make test case consistent with comments (#105). Other Go modules support (#91). Update API documentation: comments and examples (#123).
oleg-jukovec
added a commit
that referenced
this issue
Dec 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Filed here to collect opinions. Sometimes it is convenient to support API documentation in the form of annotations right within the code. Sometimes, actually, not.
I guess if we'll go with deployments to pkg.go.dev (in #121), we'll need documentation in some standard format and maybe we'll imposed to generate it from sources.
For me it is terra incornita now: need to investigate the topic and collect opinions from experienced Go developers.
If we'll go this way, I assume a considerable amount of work to actually write the annotations as part of this issue.
The text was updated successfully, but these errors were encountered: