-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insist on luatest #23
Labels
feature
A new functionality
Comments
ligurio
added a commit
that referenced
this issue
Sep 2, 2022
ligurio
added a commit
that referenced
this issue
Sep 2, 2022
ligurio
added a commit
that referenced
this issue
Sep 2, 2022
Part of #23 Related to tarantool/tarantool#5000
ligurio
added a commit
that referenced
this issue
Sep 2, 2022
Part of #23 Related to tarantool/tarantool#5000
locker
pushed a commit
that referenced
this issue
Sep 2, 2022
Part of #23 Related to tarantool/tarantool#5000
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Tarantool test suite contains tests written using different approaches.
Four test types in test-run (source)
In test-run (the test framework that we use in tarantool/tarantool) we have four types of tests (named below according to the
core
field in thesuite.ini
file):core = tarantool
: read a test file and feed it line-by-line1 to tarantool console. A text of requests and responses is squashed and compared against a reference file. Often called diff-based based testing.core = app
: just Lua script. Usually produces TAP13 output using built-intap
module (and so often called tap-based testing), which is validated by test-run without a reference file. If a test produces non-TAP13 output, stdout is compared against a reference file.core = unittest
: just executable files. May be TAP13 compliant (after some work) or diff based.core = luatest
: callsluatest <...> /path/to/foo_test.lua
, where luatest is configured to produce TAP13 output. (Reasoning.)Some time ago we agreed to write new tests using the luatest framework, because it allows to make the testing code more structed using explicit asserts and before/after test hooks.
This agreement is not obvious for the new employees and external contributors. I propose to add a check that allows to add only
unittest
andluatest
tests. Changing of existing tests, of course, should be allowed.See also tarantool/test-run#304.
Footnotes
Multiline statements should be marked explicitly either by
set delimiter
test-run command or using a backslash at end of line. ↩The text was updated successfully, but these errors were encountered: