-
Notifications
You must be signed in to change notification settings - Fork 5k
fix(docker): Re-add openjdk-17-jre-headless to Dockerfile.base #33450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @tomchon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a critical dependency issue in the Docker build process by restoring the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly re-adds the openjdk-17-jre-headless package to the base Docker image, which is a necessary dependency. I have one suggestion to improve the maintainability of the Dockerfile by sorting the package list alphabetically.
| locales \ | ||
| net-tools \ | ||
| netcat-openbsd \ | ||
| openjdk-17-jre-headless \ | ||
| tini \ | ||
| tzdata \ | ||
| valgrind \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and long-term maintainability, it's a good practice to keep package lists sorted alphabetically. This makes it easier to check for existing packages and add new ones. I've noticed the list in this section is not fully sorted. Could you please reorder the packages alphabetically?
locales \
netcat-openbsd \
net-tools \
openjdk-17-jre-headless \
tini \
tzdata \
valgrind \
No description provided.