case: tidy up cases (10.31) Migrate system-test

[DuanKuanJun]

Description

Please briefly describe the code changes in this pull request.

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @DuanKuanJun, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request undertakes a significant restructuring of the system test suite by migrating and refactoring numerous test cases. The primary goal is to move tests from a generic 'uncataloged' location into more logical, feature-specific directories. This reorganization enhances the maintainability and discoverability of tests, particularly those designed to verify specific bug fixes. The changes also streamline the test execution flow by consolidating related bug verifications under unified test methods, and the CI configuration has been updated to align with these structural improvements.

Highlights

• Test Case Migration and Renaming: Numerous test files have been migrated from the uncatalog/system-test/99-TDcase/ and uncatalog/system-test/3-enterprise/restore/ directories to more structured and categorized paths within 02-Databases/, 09-DataQuerying/, 11-Functions/, and 70-Cluster/. This includes renaming files for better clarity and organization.
• Test Method Refactoring and Bug Integration: Existing test_ methods in several files have been refactored into do_ prefixed methods (e.g., test_TS_3311 became do_ts_3311). These do_ methods are now called from a single main test_ method (e.g., test_db_precision_bugs), allowing for the grouping of related bug verifications within a single test class. This pattern is applied to tests verifying bugs like TS-3311, TS-3821, TS-3404, TD-21561, TD-19210, TS-3581, TS-5130, TS-5580, and TD-20582.
• New Test File for Dnode Restore: A new test file, test/cases/70-Cluster/test_cluster_restore_dnode.py, has been added to specifically test the dnode restore functionality within a cluster environment.
• CI Configuration Update: The test/ci/cases.task file has been updated to reflect all the new file paths and names for the migrated test cases, ensuring that the continuous integration pipeline correctly executes the reorganized test suite.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request primarily focuses on refactoring and migrating system test cases into a more organized structure. While the overall effort to tidy up the test suite is commendable, I've identified several issues, mainly related to copy-paste errors in method names, docstrings, and comments. There are also opportunities to improve code efficiency and style. Most notably, I found a critical issue in an SQL statement that will likely cause test failure, and another that will cause a runtime error due to a method name typo.