-
Notifications
You must be signed in to change notification settings - Fork 5k
docs: add usessl parameter for WebSocket connections in taosc doc #33341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @qevolg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds documentation for the usessl parameter for WebSocket connections in both the English and Chinese versions of the taosc documentation. The additions are clear and consistent with the existing documentation. However, the pull request also removes the documentation for the rotationCount parameter without explanation. I have added comments to highlight this, as it could be an unintentional error or an undocumented change that might confuse users.
| | connRetries | After 3.3.7.4 | Not supported | Maximum number of retries upon connection failure, default value: 5 | | ||
| | retryBackoffMs | After 3.3.7.4 | Not supported | Initial wait time in milliseconds after connection failure. This value increases exponentially with consecutive failures until reaching the maximum wait time, default value: 200 | | ||
| | retryBackoffMaxMs | After 3.3.7.4 | Not supported | Maximum wait time in milliseconds when connection fails, default value: 2000 | | ||
| | usessl | After 3.3.8.4 | Not supported | Enable SSL/TLS for WebSocket connections. 0: disabled (default), 1: enabled | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use useWss or useSsl (camelCase).
Does it support environment?
Does it support adapterList with https/wss scheme?
Does it support taos_options for set manually?
Does it support different scheme (http or https) in more than one cluster in single process?
Description
Add usessl parameter for WebSocket connections in taosc doc
Checklist
Please check the items in the checklist if applicable.