Skip to content

Conversation

@qevolg
Copy link
Contributor

@qevolg qevolg commented Oct 22, 2025

Description

Add usessl parameter for WebSocket connections in taosc doc

Checklist

Please check the items in the checklist if applicable.

  • Is the user manual updated?
  • Are the test cases passed and automated?
  • Is there no significant decrease in test coverage?

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @qevolg, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the taosc documentation to accurately reflect the configuration options for WebSocket connections. It introduces the usessl parameter, which allows users to enable or disable SSL/TLS for WebSocket connections, and refines the Chinese documentation by removing an outdated parameter description. The overall goal is to ensure the documentation is current and comprehensive for users configuring WebSocket connections.

Highlights

  • Documentation for usessl Parameter: The usessl parameter has been added to the WebSocket connection configuration documentation in both English and Chinese taosc reference files. This parameter enables or disables SSL/TLS for WebSocket connections, available from version 3.3.8.2.
  • Documentation Refinement: The detailed description for the rotationCount parameter has been removed from the Chinese taosc reference documentation, streamlining the content.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds documentation for the usessl parameter for WebSocket connections in both the English and Chinese versions of the taosc documentation. The additions are clear and consistent with the existing documentation. However, the pull request also removes the documentation for the rotationCount parameter without explanation. I have added comments to highlight this, as it could be an unintentional error or an undocumented change that might confuse users.

| connRetries | After 3.3.7.4 | Not supported | Maximum number of retries upon connection failure, default value: 5 |
| retryBackoffMs | After 3.3.7.4 | Not supported | Initial wait time in milliseconds after connection failure. This value increases exponentially with consecutive failures until reaching the maximum wait time, default value: 200 |
| retryBackoffMaxMs | After 3.3.7.4 | Not supported | Maximum wait time in milliseconds when connection fails, default value: 2000 |
| usessl | After 3.3.8.4 | Not supported | Enable SSL/TLS for WebSocket connections. 0: disabled (default), 1: enabled |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use useWss or useSsl (camelCase).

Does it support environment?
Does it support adapterList with https/wss scheme?
Does it support taos_options for set manually?
Does it support different scheme (http or https) in more than one cluster in single process?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants