Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2 color dash line #26

Open
sensescape opened this issue Aug 2, 2016 · 7 comments
Open

2 color dash line #26

sensescape opened this issue Aug 2, 2016 · 7 comments
Assignees
Milestone

Comments

@sensescape
Copy link
Member

Hi! @patriciogonzalezvivo

Could we try a dash line with 2 colors? And the ability to set the background color too?

screen shot 2016-08-02 at 9 08 17 am

@patriciogonzalezvivo
Copy link
Contributor

Sure! We should sit down together and plan this... as part of the optimisation we should transform as much geometry we can to shaders...

Could you prepare some snapshots of routes styles we need... and what properties should be configurable like:

background_color
dash_width:
dash_height:
dash_space:

@sensescape
Copy link
Member Author

Thanks! Sure, to add to the above:

background_color
dash_width:
dash_height:
dash_space:
dash1_color:
dash2_color:

Not sure yet how I'll use it, still sketching, but yes let's optimize when finalized

Like the highways? Should we change that to shader form?

@patriciogonzalezvivo
Copy link
Contributor

Yes, right now... the road, glow, outline, and dashes add one geometry each one... that produce over draw + different custom shaders... all that slows down things... the idea is once we have something we like to put it together into less layers...

probably the roads will contain the dashes and traffic animations (that they already had)
and the outline will provide also the glow... so the size need to be changed (bigger)

@sensescape
Copy link
Member Author

Ok, I think the highway is ready to be converted to shader form.

@nvkelso nvkelso added this to the 2.1 milestone Aug 31, 2016
@patriciogonzalezvivo
Copy link
Contributor

future: speaking w @bcamper I realize this as a shader is more expensive... tangram (as is) have great support for pattern textures on lines... we should use that

@nvkelso
Copy link
Member

nvkelso commented Oct 11, 2016

Can you create a new issue to track this, please?

On Tue, Oct 11, 2016 at 12:03 PM, Patricio Gonzalez Vivo <
[email protected]> wrote:

future: speaking w @bcamper https://github.com/bcamper I realize this
as a shader is more expensive... tangram (as is) have great support for
pattern textures on lines... we should use that


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#26 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AA0EOyCszidBem0BAyU9v27_WLM318Ncks5qy91pgaJpZM4JayO-
.

@patriciogonzalezvivo
Copy link
Contributor

is technically "not an issue". Just a note for the future (because is a 2.1 goal) that this should be address with the existing lines texture patterns.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants