Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Reservation schedule display goes off the edge of the screen if it extends to midnight #565

Open
MichaelZhao21 opened this issue Apr 18, 2023 · 0 comments
Labels
Arc: Frontend Frontend development Status: Needs Triage Issue needs to be assigned Type: Bug Something isn't working

Comments

@MichaelZhao21
Copy link
Member

Describe the bug

Because of the way I coded the span and the fact that it cuts off at 10pm, there is no check for if the event goes to midnight. And since the name is centered on the reservation block, it cuts off the name.

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://tams.club/events/reservations/2023/4/16
  2. The event "HOPE Meeting" is cut off

Expected behavior

The span calculation should take in consideration that nothing shows after 10pm. However, it should still show the right time on hover.

Screenshots or Links

image

Environment

  • OS: Linux
  • Browser: Firefox
  • Browser Version: 111.0.1

Additional context

N/A

@MichaelZhao21 MichaelZhao21 added Type: Bug Something isn't working Arc: Frontend Frontend development Status: Needs Triage Issue needs to be assigned labels Apr 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arc: Frontend Frontend development Status: Needs Triage Issue needs to be assigned Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant