Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Client ID hardcoded for some reason on login page #558

Open
MichaelZhao21 opened this issue Sep 6, 2022 · 0 comments
Open

[BUG] Client ID hardcoded for some reason on login page #558

MichaelZhao21 opened this issue Sep 6, 2022 · 0 comments
Labels
Context: Refactor Clean and organize code Status: Needs Triage Issue needs to be assigned Type: Bug Something isn't working

Comments

@MichaelZhao21
Copy link
Member

Describe the bug

In the code, the CLIENT_ID is hardcoded in client/pages/profile/index.tsx on line 41.

Expected behavior

This should probably go in some environmental variable or config file. If that's not possible, it's probably still a good idea to put into the data.json file.

Screenshots or Links

If applicable, add screenshots or links to other media to help explain your problem.

Environment

N/A

Additional context

image
@MichaelZhao21 MichaelZhao21 added Type: Bug Something isn't working Context: Refactor Clean and organize code Status: Needs Triage Issue needs to be assigned labels Sep 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Context: Refactor Clean and organize code Status: Needs Triage Issue needs to be assigned Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichaelZhao21