Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Edit history does not save correctly #555

Open
MichaelZhao21 opened this issue Aug 23, 2022 · 2 comments
Open

[BUG] Edit history does not save correctly #555

MichaelZhao21 opened this issue Aug 23, 2022 · 2 comments
Assignees
Labels
Arc: Backend Backend development Arc: Frontend Frontend development Priority: High Important issue or element that needs to be fixed or added Status: In Progress Issue that is currently being worked on Type: Bug Something isn't working

Comments

@MichaelZhao21
Copy link
Member

Describe the bug

Individual events don't seem to be saving edit history. It's strange because some events do seem to save their history, but a lot of the events don't have an edit history attached to them :/

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://tams.club/edit/history/events/07d1f5cf-b38e-458d-863a-beedcdf28b74
  2. It doesn't seem to have an edit history :(

Expected behavior

It should create an edit history object whenever an event is created.

Screenshots or Links

Could possibly be broken by #547

Environment

N/A

Additional context

Add any other context about the problem here.

@MichaelZhao21 MichaelZhao21 added Type: Bug Something isn't working Priority: High Important issue or element that needs to be fixed or added Arc: Frontend Frontend development Arc: Backend Backend development Status: Needs Triage Issue needs to be assigned labels Aug 23, 2022
@MichaelZhao21
Copy link
Member Author

This seems to also cause the site to crash occasionally:

TypeError: Cannot read properties of null (reading 'save')
    at /app/server/app.js:202:19156
    at runMicrotasks (<anonymous>)
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
node:internal/errors:477
    ErrorCaptureStackTrace(err);
    ^

ah yes... javascript errors >:((

@MichaelZhao21 MichaelZhao21 self-assigned this Sep 4, 2022
@github-actions github-actions bot added Status: In Progress Issue that is currently being worked on and removed Status: Needs Triage Issue needs to be assigned labels Sep 4, 2022
@MichaelZhao21
Copy link
Member Author

Hmm... it seems like history entries with the resourceId of "events" are being deleted. This could potentially be caused by the deletion of repeating events (not working properly). Besides that, it seems NEW edit histories are being created correctly. Note that these issues does NOT affect the clubs or volunteering resources, only events.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arc: Backend Backend development Arc: Frontend Frontend development Priority: High Important issue or element that needs to be fixed or added Status: In Progress Issue that is currently being worked on Type: Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant