History list pagination currently is just checking to see if the list gotten has a length of 50 or not #491
Labels
Arc: Backend
Backend development
Arc: Frontend
Frontend development
Priority: Medium
Medium priority items (everything else is low)
Status: Needs Triage
Issue needs to be assigned
Type: New Feature
New feature or request
Comments
MichaelZhao21
added
Type: New Feature
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Is your feature request related to a problem? Please describe.
/client/src/components/edit/history/history-list.jscomponentCurrently, if the length is 50, then that means that we have gotten the max # of edits to show on the current page and there are more pages of edits to show. This means that if there are a multiple of 50 pages, then it would always show the "load more" button and wouldn't do anything after reaching the end. This is honestly a very JANK way of resolving pagination; the actual way to do this is when fetching for data, send a boolean attribute informing the frontend whether or not there are more pages in the history.
Describe the solution you'd like
We should return a boolean value from the backend when requesting history pagination.
Describe alternatives you've considered
Or we could just not do it as we have over 2k history entries and counting.
Additional context
Honestly, this should never be a problem as there are THOUSANDS of edits, butttttttttt you know it's good to have a backup
The text was updated successfully, but these errors were encountered: