Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] JS/JSX should be changed to TS/TSX in the CONTRIBUTING file #465

Open
MichaelZhao21 opened this issue May 26, 2022 · 0 comments
Open

[BUG] JS/JSX should be changed to TS/TSX in the CONTRIBUTING file #465

MichaelZhao21 opened this issue May 26, 2022 · 0 comments
Labels
Arc: Documentation Documentation or contribution info improvements good first issue Good for newcomers Status: Needs Triage Issue needs to be assigned Type: Bug Something isn't working

Comments

@MichaelZhao21
Copy link
Member

Describe the bug

We have updated to Typescript, but the documentation seems a bit outdated :(

To Reproduce

Steps to reproduce the behavior:

  1. Go to https://github.com/MichaelZhao21/tams-club-cal/blob/master/CONTRIBUTING.md#jsjsx-conventions

Expected behavior

https://github.com/MichaelZhao21/tams-club-cal/blob/master/CONTRIBUTING.md#jsjsx-conventions should say "TS/TSX Conventions"

Screenshots or Links

image

Environment

  • OS: Windows 10 (64-bit)
  • Browser: Firefox
  • Browser Version: 95.0

Additional context

Add any other context about the problem here.
@MichaelZhao21 MichaelZhao21 added Type: Bug Something isn't working Status: Needs Triage Issue needs to be assigned Arc: Documentation Documentation or contribution info improvements good first issue Good for newcomers labels May 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Arc: Documentation Documentation or contribution info improvements good first issue Good for newcomers Status: Needs Triage Issue needs to be assigned Type: Bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@MichaelZhao21