Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minior's core form shiny sprite is highly inaccurate #11

Open
OpenSauce04 opened this issue Jun 19, 2024 · 4 comments
Open

Minior's core form shiny sprite is highly inaccurate #11

OpenSauce04 opened this issue Jun 19, 2024 · 4 comments

Comments

@OpenSauce04
Copy link

When attempting to show Minior's shiny sprite, the same colour as the non-shiny version is shown with different shading instead of the expected black core:

@OpenSauce04
Copy link
Author

OpenSauce04 commented Jun 19, 2024

This appears to be a holdover from the upstream pokesprite repo.

For whatever reason, there is a correct shiny sprite in the same respository with a -gen7 suffix despite not being in the gen 7 folder. Any idea why this is the case?

@talwat
Copy link
Owner

talwat commented Jun 20, 2024

This appears to be a holdover from the upstream pokesprite repo.

For whatever reason, there is a correct shiny sprite in the same respository with a -gen7 suffix despite not being in the gen 7 folder. Any idea why this is the case?

No idea, but if that's the case then it'll be almost impossible to fix on the pokeget side, since it's not worth forking the whole repo to fix a bug. For now, it'll probably have to be stuck like this, but when they fix it i'll be able to pull the changes into pokeget.

@OpenSauce04
Copy link
Author

In the meantime I have discovered that you can still get the correct sprite by typing out the full correct file name, which works in my case because I'm running from a script.

@talwat
Copy link
Owner

talwat commented Jun 21, 2024

Yeah, I made pokeget pretty flexible when it comes to how you're actually picking the sprites, so for scripts it should work fine :)

I'll keep this open to remind myself to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants