Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove dependency of Android NDK and all forms of C/C++ code #9

Open
ghost opened this issue Nov 30, 2021 · 2 comments
Open

remove dependency of Android NDK and all forms of C/C++ code #9

ghost opened this issue Nov 30, 2021 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@ghost
Copy link

ghost commented Nov 30, 2021

liblouis, the only braille translator, is in C and depends on Android NDK (for native code) to build Talkback

https://github.com/talkback-foss-team/talkback-foss/tree/main/braille/src/main/jni

That needs to be replaced with something else that does not use C.

Not a high priority.

@ghost ghost added enhancement New feature or request help wanted Extra attention is needed labels Nov 30, 2021
@ghost
Copy link
Author

ghost commented Nov 30, 2021

If not, someone experienced in C needs to take a look at the code as it's highly unmaintained and there is a lot of memory safety concerns in it, something GrapheneOS's hardened_malloc would catch.

It needs to be tested properly too with Braille.

@PatrykMis
Copy link
Member

Would be glad to see liblouis rewritten in Kotlin, Java or at least Rust.

Seams we should watch for Liblouis updates as most of the last version changes are those regarding memory corruptions / leaks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

1 participant