Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verbosity/Punctuation: Missing spaces between character names and surrounding text. #32

Open
personalizedrefrigerator opened this issue Jun 9, 2022 · 2 comments

Comments

@personalizedrefrigerator
Copy link

personalizedrefrigerator commented Jun 9, 2022

Note: I'm still trying to build and install this version of TalkBack. I will close this issue if it's been fixed here.

Summary

Spaces are not inserted between the names of punctuation characters and the surrounding text when Verbosity > Miscellaneous > Punctuation is on.

Steps to reproduce

  1. Enable Verbosity > Miscellaneous > Punctuation
  2. Enable TalkBack
  3. Have TalkBack read "This.sentence.contains.punctuation"

Observed behavior

ThisPeriodsentencePeriodcontainsPeriodpunctuation is read out loud (can be confirmed by enabling Advanced settings > Developer settings > Display speech output).

Relevant links

@Nullable String cleanValue = SpeechCleanupUtils.characterToName(mContext, ch);

Version information

13.1.02.0/Google

@PatrykMis
Copy link
Member

Thanks for the well-described issue. I'll look into it once I rebase to upstream v12.2 and make tag / release (unfortunately, no source for v13.x yet).

I am visually impaired too and I'm learning yet, it's my hobby project. Unfortunately we have no interest from developers right now.

@personalizedrefrigerator
Copy link
Author

I might have time to work on this in the next few weeks. If so, I'll open a pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants