Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve nomenclature of error-handling functions #94

Open
dblohm7 opened this issue Aug 30, 2024 · 0 comments
Open

Improve nomenclature of error-handling functions #94

dblohm7 opened this issue Aug 30, 2024 · 0 comments

Comments

@dblohm7
Copy link
Member

dblohm7 commented Aug 30, 2024

          It appears that the returned error is unused. And it is in fact unused, but `newError` also logs it, and panics if panicking on error is enabled. So, I think it works correctly and as intended and is just not super clear from the context.

This is probably the second instance where we use newError this way. Maybe we should add a reportError or logError function that calls newError under the hood but makes the intended behavior clearer?

Originally posted by @nickkhyl in #89 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant