Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix indeterministic password test case #10

Open
tafaust opened this issue Apr 4, 2022 · 0 comments
Open

Fix indeterministic password test case #10

tafaust opened this issue Apr 4, 2022 · 0 comments
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed

Comments

@tafaust
Copy link
Owner

tafaust commented Apr 4, 2022

https://github.com/tahesse/policy-password/blob/main/test/password.test.ts#L95-L104

is not deterministic and can cause the CI pipeline to fail.
Suggested solution:

Add a boolean flag to circumvent this issue and provide users of this library to prevent uni-letter passwords.
@tafaust tafaust added bug Something isn't working enhancement New feature or request help wanted Extra attention is needed labels Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tafaust