Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No media queries for colors #318

Closed
overlandandseas opened this issue Jan 1, 2017 · 3 comments
Closed

No media queries for colors #318

overlandandseas opened this issue Jan 1, 2017 · 3 comments

Comments

@overlandandseas
Copy link

There for no breakpoints for colors, background or text.
This could be bad responsive design, or a decision could have been made to not have these.
But they would sure come in handy for me.

Example: red blue-l
Would be red up until the large break point and then text would change to blue.

@zehfernandes
Copy link

zehfernandes commented Jan 12, 2017

We forked tachyons and made this custom change.
https://github.com/vtex-apps/vtex-tachyons/blob/master/src/_skins.css#L183

Using the Breakpoint generator CLI from this pull request
tachyons-css/cli#13

it's been useful for remove background color at popover desktop elements.

@overlandandseas
Copy link
Author

@zehfernandes Oh nice! I actually ended up doing the same. Haven't pushed it up though.

@mrmrs
Copy link
Member

mrmrs commented Jan 19, 2017

It adds too much weight to core to provide breakpoints for all color values currently.
It used to be in older versions of tachyons, but eventually I trimmed it down as I didn't use it often enough. Ideally we'll just make it as easy as possible for you to add breakpoints for colors if you want them but will keep it opt-in for the user.

@mrmrs mrmrs closed this as completed Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants