Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with fullscreen in Pale Moon 28 #145

Open
EbonJaeger opened this issue Jun 3, 2018 · 10 comments
Open

Issues with fullscreen in Pale Moon 28 #145

EbonJaeger opened this issue Jun 3, 2018 · 10 comments

Comments

@EbonJaeger
Copy link

In Pale Moon 28, the event model for going to/from fullscreen changed. This causes issues with the auto-hiding of the tab bar; the bar is not hidden after entering fullscreen, and then it is hidden when exiting fullscreen.

On the Pale Moon forums I was linked to this PR which may be of some use: https://github.com/MoonchildProductions/UXP/pull/313

@PikachuEXE
Copy link
Member

Oh, let me try to restore the option for full screen this weekend...

@EbonJaeger
Copy link
Author

That would be awesome! I have a feeling there's a few other issues with this update as well, if you'd like more issues. xD

This version is a bit of a jump.

@EbonJaeger
Copy link
Author

The preference that was re-added seems to work on PM 28; the tab bar seems to hide on fullscreen videos now. However, this exposes a different problem: when fullscreen, all that appears on the screen is this:
pm_tabkit2_fullscreen_1

I think I saw this occur on PM 27 too, so I suspect this is part of a different issue. If you want, I can file it separately to keep track of things.

@PikachuEXE
Copy link
Member

Where do I find PaleMoon 28 though?

@EbonJaeger
Copy link
Author

@PikachuEXE
Copy link
Member

Let me try it next weekend

@EbonJaeger
Copy link
Author

No worries. I'd help, but I wouldn't quite know where to start. I'm still trying to learn the NoSquint codebase. Heh.

@PinkCathodeCat
Copy link

Was there any progress on this? It still happens on palemoon 28, with an i3 window manager.

@PikachuEXE
Copy link
Member

OK 28 stable is out, time to start working :3

@PikachuEXE
Copy link
Member

0.13.3 released for Palemoon 28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants