Not work under new Firefox 52

[luweitest]

I just updated from FF51 to 52, and found that the right-sided tabs goes to the top again. I go to addon options and test but the setting do not function anymore.

[mallardduck]

@luweitest I'm fairly certain this was an issue caused by Firefox removing XUL extension support. I believe that I saw @PikachuEXE mention in another Issue that they are working on some major rewrites that would fix this issue.

I would keep an eye on things tagged as: FF 52.x Support

[analytik]

XUL support hasn't been removed. This page summarizes the changes for Firefox 52.

Vertical Tabs extension works in Firefox 52, albeit it's a bit wonky now.

[JRPtau]

Yes, it stopped working in FF 52.0 (64-bit). It seems that not only right-siding, but other options as well.

[mallardduck]

Ahh, interesting @analytik.

Although since the last working build was 45.7.XX this probably is still related to deprecations of XUL related functions. I can get the plugin working fine on the 45.x ESP version of Firefox but nothing after that. So it's likely that the cause, and solution, is related to something removed between 45.x and 52.x.

Update: Taking a quick look at the other version summaries for 45-51, I'm not seeing anything explicitly stating that XUL related functionality was removed or changed in a way that would cause breaks. So I guess I could be wrong that it's related to XUL, who knows. 🤷‍♂️

[PikachuEXE]

It's due some Firefox internal changes & old code written in the deprecated way (according to JavaScript standard) stop working.
Which is why the extension does work in FF 52 at all.

I will release a new version this week.
Though expect some issues with it.
So stay on FF 45.x if you want to be safe.
And keep some backup of your profile before upgrading Firefox + TabKit.

[mallardduck]

I don't have much experience with Firefox plugin development, but if there's anyway I can help let me know!

I work at a hosting company where a LOT of staff uses this addon for Firefox to be more productive. A lot of system administrators use this to ensure they can keep track of their work and to group up tabs by project/customer. So I'd love to be able to help contribute back since I personally (and many of my coworkers) benefit from the plugin.

Really, let me know if there's anything I can do. Even if it's just helping with docs or something. I'd like to help make sure this plugin can get updated to work with recent Firefox versions as there could be security risks involved with running an outdated Firefox version.

[analytik]

I'll actually donate a tiny bit for Fx 52 compatibility. Is there any active contributor besides PikachuEXE, and which way of transferring money do you prefer? Maybe make a small kickstarter? :D

[PikachuEXE]

Released v0.12.6 for FF 52
Need to wait for approval though

[Boovov]

is there a way to install v0.12.6 before then if you wish to play with it?

[mallardduck]

I think we can just manually install the current state of master on top of the plugin folder under .Mozilla/Firefox/user.default/. Once I'm at home, I'll give this a shot and will report back.

[mallardduck]

Ok, so I'm pretty close. You can test this with the following:

1. Download current state of master
2. Rename the src folder to: [email protected]
3. replace install.rdf inside src (now renamed) with the contents of /versions/beta_release/install.example.rdf
4. copy this folder to your profiles extension directory.

You will need to be on ESR or nightly version of firefox to test the extension. You also may need to adjust a setting in about:config to enable unsigned extensions. xpinstall.signatures.required to false.

---

From my testing it seems that the extension is not fully working yet. Although I'm testing outside of an environment I'd actually use it in. I'm testing with windows 10 on Firefox 52 ESR release (64-bit).

[PikachuEXE]

@mallardduck
There are more steps to install it locally from master.
Maybe I will write them down later.

For now just use the built one: (need to upload a zip since GitHub disallow .xpi)
tab_kit_2nd_edition-0.12.16-fx.xpi.zip

[mallardduck]

Sorry about that, I didn't realize that was the case. Now I do see the gulp and yarn files though so I see the error in my logic. xD

Thank you for providing the XPI file for testing! It does seem to be far more functional that I stated! On windows at least I'm seeing a few odd issues still. I needed to enabled the Menu bar to stop the firefox window menus from colliding with the hamburger menu.

I also noticed some reactivity issues related to the mouse and browser/page elements. For instance when i went to disable the extension the Enable button was non-responsive to hover events and I had to rapidly click before it registered a click.

Again, Windows is not my normal testing environment so it could just be something funky there. When I'm at work I'll test the XPI on linux and report back.

Thanks @PikachuEXE for all your efforts and hard work!

[analytik]

Awesome, thanks a bunch PikachuEXE!

It works mostly well (Win 7 x64), except for scroll wheel to switch tabs (vertical layout). Haven't noticed other bugs yet.

[PikachuEXE]

@analytik
Thats related to another "extracted" extension
https://addons.mozilla.org/en-US/firefox/addon/tab-kit-mouse-gestures/
I already fixed the scroll issue and released a new version
But you need to update it ;)

[Boovov]

I just testing it on my (Win 10 x64) laptop, and I had the same problem that mallardduck ran into, a fair amount of the visual elements in FF would not let me click them, and instead minimize and maximize the browser. I did also notice that if I rapidly clicked over a button it would eventually click the button I was trying to click on.

Easy to test if you just try to go to appearance tab and change appearances in firefox.

[LookingForWayOut]

I tried to manually install the XPI in the zip file above, but FF denied it.
Any thoughts to when FF will find ti updateable on its own from the servers where the approved software goes?

[PikachuEXE]

@LookingForWayOut
You can try Firefox Dev version 52
That version allow installation of unsigned XPI (after changing a config)

If you are on Windows you can even try portable version (cleaner)
https://sourceforge.net/projects/portableapps/files/Mozilla%20Firefox%20Developer%20Portable/

[Boovov]

hey @PikachuEXE any word on if they are going to accept the new version of the addon? or about the slight bug I mentioned above at #131 (comment)

[PikachuEXE]

@Boovov
Thanks for reminding me
I just checked the status for the new version:
Queue Position: 51 of 261
Which is why I am against extension signing without an option to turn it off

[PikachuEXE]

Today: 46 of 265
Do they only work 1 day per week?

[Boovov]

Jeez I hope not, I use this plugin to manage my workflow at work and not having it really kills me, lol. Waiting another 9 weeks, does not sound fun.

[PikachuEXE]

@Boovov
Try https://vivaldi.com/
I use it for daily operations

It does takes more memory since it's based on Chromium too
But the UI is much better than Google Chrome
Got mouse gestures (even more powerful than Tab Kit - Mouse Gestures)

It's tab grouping feature "Tab Stack" looks strange when tab bar is set to be on left/right though :P
I use multiple windows right now if needed, instead of a long list of tabs

[conklinsys]

Did it ever get signed?

[mallardduck]

@conklinsys it took 9 days for the plugin to move 5 places up the queue. I would guess we'll be waiting quite a while longer unless they speed up their approval process.

[conklinsys]

Well an option - I switched over to Waterfox, which is tracking FF very closely (seemed simultaneous release) but takes out several of the Mozilla we-know-what's-best-for-you changes, and Tabkit's working fine with it from the .zip file.

Actually better than it has for a while. Somewhere along the line tab color groups stopped persisting in FF.

[PikachuEXE]

Finally reviewed
Here is what they said:

A quick note: the comparing tool we use for reviewing show diff in restrictive ways, and the huge tabkit.js file showed as completely changed, maybe due to reformatting or some space adding in lines. It makes it almost impossible to find the lines with real changes. I believe that's part of the reason your version took so long to review.

[JRPtau]

Finally! It works!! Many thanks for all your efforts!!!

[PikachuEXE]

Not yet
Find why it's wrong is not easy (need to keep using console.log to see internal states)

[Boovov]

is there a document that I can look at to help trouble shoot it? I can replicate it 100% every time.

I do find it super strange that if I hold down the right mouse button the left one works as expected. makes me think that there is something up with the right click mouse functions that are broken.

[PikachuEXE]

@Boovov @conklinsys

It would be great if you can reproduce the bug with a portable version of Firefox ESR
and upload the whole folder in a zip file here once reproduced

I cannot reproduce the left click bug with youtube video

You can use my custom packaged version of Firefox ESR Portable
It has a tab kit extensions installed and a tab of youtube video
And/or download a clean Firefox ESR Portable
https://portableapps.com/apps/internet/firefox-portable-esr

Custom packaged version of Firefox ESR Portable:
https://mega.nz/#!IxgwlDbR!bgMPcSNEM2iVHKIc3zm_2Na4PEziNYSg-_YdGADJTh4

[conquerist]

I also had trouble interacting with UI elements with FF 52 and TK 0.12.16. It made FF unusable, see below for a description of what was wrong. However, I was able to fix it by unchecking

Use Firefox titlebar instead of OS titlebar
about:config > > browser.tabs.drawInTitlebar

under Firefox button in the Classic Theme Restorer (CTR) settings.

@PikachuEXE
This CTR setting is already mentioned in README.md, however the CTR options page has changed in the meantime and the readme still refers to the setting by it's old location and description. For me, FF45 worked perfectly fine with this box in the CTR settings left at its default (checked).

@Boovov
Can you toggle this setting in CTR and see if it changes anything for you?

Experienced behavior

• On nearly all elements, the displayed website doesn't react to mouse-over or single clicks. For example, hyperlinks don't underline on mouse-over (hovering) and single clicking on a link does nothing.
  • Example of an element where interaction with the mouse does work: The OK button in the Tab Kit First Run Wizard.
• If the window isn't maximized, clicking-and-dragging anywhere on the page causes the entire window to move, as if clicking-and-dragging the titlebar.
• Double clicking where there isn't a link causes the window to toggle between maximized and restored state.

Workarounds / Fixes

• Double clicking on a link results in the (single click?) action being performed. As a side effect it also toggles the window between maximized and restored state.
• Pressing and holding the right mouse button causes the mouse-over and single clicking to work as expected.
• Changing Classic Theme Restorer settings as described above.

[Boovov]

Hello,

@conquerist unchecking that box does indeed make everything work again as expected, but now i have 2 title bars. I hope knowing that can direct @PikachuEXE in a direction.

I will re-check it and try to get @PikachuEXE the info s/he asked for to help also.

I will reply again soon.

[Boovov]

@PikachuEXE I have downloaded the portable version, and set it up to duplicate the addons that I have installed. To give you the full work space that I use.

boovov-modified-FirefoxPortableESR.zip

When you launch it. it should launch with a single tab open that has youtube up in it.

1. if you try to single left click on any video image, nothing will happen.
2. if you double click on any video image, the browser will really quickly minimize, and then maximize but it will load the video.
3. if you go back to the main page of youtube at this point, and hold down the right mouse button you will be able to use the page normally.

Let me know once you have downloaded the file so I can remove it from my file server.

I hope this helps.

[PikachuEXE]

@Boovov
I have downloaded the file
You can remove it now

@conquerist
I confirm the workaround works
Just not sure why it causes the bug

[mbancha]

Any update on this?

[worksong]

I foolishly upgraded to 52.2.0esr, & everything fell apart. Worse--the last version for which I saved the setup was 45.2.0esr.

1--Can anyone recommend a more current esr version which supports TabKit?
2--Does anyone know the URL of the 'secret' page where Mozilla allows downloading of old versions?

Thanks. I can't work without TabKit2.

[gituser]

@worksong, update all your plugins in 52.2.0esr and it should be sorted.
tabkit2 works fine for me so far with 52.2.0esr (32bit).

[worksong]

Tried, but no luck. 300+ tabs, & I'm forced to scroll 1 by 1 across the top bar. I'm back to 45.2.0esr [which immediately updates to 45.3.0esr].

Thanks. Anyone have other ideas?

[PikachuEXE]

The latest TK2 should work with 52.x
I am using right now
What's your TK2 version?

Edit: and how do you use it (horizontal / vertical)

[worksong]

Sorry to be dense, but where can I find the .xpi file? I don't see it on github, & updating from extensions list obviously not an option.

[I'm on 0.12.15, use exclusively vertical, & find it INDISPENSABLE for managing large groups of projects while maximizing screen space.]

[PikachuEXE]

I guess you can use auto update feature?
Or find all versions at
https://addons.mozilla.org/en-US/firefox/addon/tabkit-2nd-edition/versions/

[worksong]

Auto update not working, but I updated manually. Very long story short:

• 0.12.17 not working with 52.2.0esr. All looks/seems fine...except cursor & links are disabled in main viewing window. Tabs can still be manipulated & activated, but no content is accessible; it can be scrolled, but there is no interaction.

• same is true for 0.12.16

• To facilitate testing, I did all updates & checks with 5 or fewer tabs.

• could not install 0.12.17 [or 0.12.16] on FF 45.x

• only working & stable configuration I can find is 0.12.15 on FF 45.2.3esr

Would very much like to upgrade FF to 52; any help would be appreciated. Please advise if you need more detail. Thanks.

[PikachuEXE]

Have you also checked the setting of CTR?
Like this:
#131 (comment)

[worksong]

Thanks, but I've never used CTR. Are you suggesting that installing it would help?

[PikachuEXE]

https://github.com/tabkit/tabkit2#dependent-extensions
It's kind of "required" to make TK2 works properly.
Maybe you have it installed already :P

[worksong]

1--working now. Sorry. I've been relying on TK2 for years, somehow w/o CTR.

2--can you comment on this CTR note & its impact early next year?

"This add-on will stop working when Firefox 57 arrives in November 2017 and Mozilla drops support for XUL / XPCOM / legacy add-ons. It should still work on Firefox 52 ESR until ESR moves to Firefox 59 ESR in 2018 (~Q2). There is no "please port it" or "please add support for it" this time, because the entire add-on eco system changes and the technology behind this kind of add-on gets dropped without replacement."

[PikachuEXE]

Stay on 52.x (which only works for a year or something)
and/or switch to another browser

• PaleMoon, or
• another Firefox fork which supports XUL, or
• Other browsers (for vertical tab I use Vivaldi, not as good as Firefox with the extensions I have, but what can I say)

[worksong]

Thanks...but these are not viable options. 1 example of many: I need to work with a password manager, & neither of these are supported by the majors [or likely to be any time soon].

Given how much screen real estate can be freed up--not to mention tab grouping & management capabilities--I'm still amazed that no major browser has vertical options anywhere near as good as TK2.

[PikachuEXE]

I never understand the tab UI/UX design trend from the browser.
Webpages are designed for long vertical scrolling ages ago.
But design of tabs in browsers are still "stuck" in horizontal mode.
This looks very strange to me.

Anyway if XUL support is dropped, the only tree style tab thing I can think of is
https://forum.vivaldi.net/topic/15332/tree-tabs
The tab bar is shown in web panel (sidebar) in Vivaldi.
The "new Firefox" would also require something like this to implement vertical tab bar.

[gituser]

@PikachuEXE, do you accept donations for rewriting TabKit2 for new Firefox or it's not possible at all?

[worksong]

Agree w/gituser. @PikachuEXE What would it take besides fan letters to convince you to make TK2 work with new-gen FireFox?

[PikachuEXE]

Let me take a screenshot this weekend to let you know how it looks when implemented in sidebar.

Edit:
I mean with https://forum.vivaldi.net/topic/15332/tree-tabs.
There is firefox version too (I haven't tried yet)

[JRPtau]

Actually, right now TK2 works under FF 54.0 (64 bit), Win7.

[worksong]

@PikachuEXE JRPtau comment is interesting; do you recommend staying on esr or switching to main channel?

[PikachuEXE]

Use ESR if you don't want to it stop be broken suddenly after some update