Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use id instead of name for recruitment #20

Open
Metacinnabar opened this issue Aug 12, 2021 · 2 comments
Open

Use id instead of name for recruitment #20

Metacinnabar opened this issue Aug 12, 2021 · 2 comments
Assignees

Comments

@Metacinnabar
Copy link
Contributor

Overview

As shown here, recruitment messages rely on usernames instead of user ids.

This breaks things such as when a user changes their name, or if their name has # in it.

@Metacinnabar
Copy link
Contributor Author

From looking at the pre-existing code, the only fix I can think of is adding the user id to the embed author such as GoodPro712#1733 (550907912281915412), and then using that id to distinguish the author instead of using their username (which also has other issues such as if someone has a # in their username). Please let me know what you think the correct way to fix this is.

@Jofairden Jofairden self-assigned this Jun 9, 2022
@Jofairden
Copy link
Member

This should be using the UUID (discord snowflake id of the user)
It can simply be compared against the uuid of the author of the embed embed.Author.Id == user.Id

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants