Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PackageManagerTree= in image directory no longer falls back to mkosi.skeleton/ #2874

Closed
septatrix opened this issue Jul 15, 2024 · 2 comments · Fixed by #2944
Closed

PackageManagerTree= in image directory no longer falls back to mkosi.skeleton/ #2874

septatrix opened this issue Jul 15, 2024 · 2 comments · Fixed by #2944
Labels

Comments

@septatrix
Copy link
Contributor

mkosi commit the issue has been seen with

main

Used host distribution

Fedora 40

Used target distribution

Fedora 40

Linux kernel version used

6.9.8-200.fc40.x86_64

CPU architectures issue was seen on

None

Unexpected behaviour you saw

My previously working build started to fail due to dnf not finding a match for packages from additional repos.
Checking with mkosi summary it reports Package Manager Trees: none instead of .../mkosi.images/system/mkosi.skeleton like it did previously.

Moving the skeleton tree to the main image, or moving it to mkosi.pkgmngr/ results in it being correctly picked up.

Used mkosi config

No response

mkosi output

No response

@septatrix septatrix added the bug label Jul 15, 2024
@DaanDeMeyer
Copy link
Contributor

@septatrix I think this is fallout from the config parsing rework. Package manager trees are a univeral property so they're explicitly passed to the subimages which causes the default one to not be picked up even if there are none in the main image. I recommend either of the solutions you already came up with or explicitly configuring PackageManagerTrees= in the subimage which should also make it get picked up.

@septatrix
Copy link
Contributor Author

Maybe universal options should not be explicitly passed to subimages if they are none (unless explicitly set to none)? At the very least the current behavior contradicts what is written in the docs.

For the time being I moved it to mkosi.pkgmngr

DaanDeMeyer added a commit to DaanDeMeyer/mkosi that referenced this issue Aug 6, 2024
This makes sure that subimages use default values for list based
settings unless they were explicitly configured in configuration or
on the command line or have a non-empty default value in the main
image.

Fixes systemd#2874
DaanDeMeyer added a commit to DaanDeMeyer/mkosi that referenced this issue Aug 6, 2024
This makes sure that subimages use default values for list based
settings unless they were explicitly configured in configuration or
on the command line or have a non-empty default value in the main
image.

Fixes systemd#2874
DaanDeMeyer added a commit to DaanDeMeyer/mkosi that referenced this issue Aug 6, 2024
This makes sure that subimages use default values for list based
settings unless they were explicitly configured in configuration or
on the command line or have a non-empty default value in the main
image.

Fixes systemd#2874
DaanDeMeyer added a commit to DaanDeMeyer/mkosi that referenced this issue Aug 6, 2024
This makes sure that subimages use default values for list based
settings unless they were explicitly configured in configuration or
on the command line or have a non-empty default value in the main
image.

Fixes systemd#2874
DaanDeMeyer added a commit to DaanDeMeyer/mkosi that referenced this issue Aug 6, 2024
This makes sure that subimages use default values for list based
settings unless they were explicitly configured in configuration or
on the command line or have a non-empty default value in the main
image.

Fixes systemd#2874
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

Successfully merging a pull request may close this issue.

2 participants