Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

peci: Unplugging display from TBT port causes command timeouts #369

Open
crawfxrd opened this issue Jun 21, 2023 · 1 comment
Open

peci: Unplugging display from TBT port causes command timeouts #369

crawfxrd opened this issue Jun 21, 2023 · 1 comment

Comments

@crawfxrd
Copy link
Member

crawfxrd commented Jun 21, 2023

  • Model: oryp11
  • EC version: dd555b9
  • OS: Pop!_OS 22.04
  • Kernel: 6.2.7-060207-generic

Unplugging a display connected to the TBT port causes PECI GetTemp() timeouts.

Steps to reproduce

  1. Plug in a display to the TBT port
  2. Power on system, booting to OS
  3. Unplug the display

Expected behavior

  • PECI commands resume normal operation
  • CPU temp reporting is accurate

Actual behavior

  • PECI commands begin timing out and do not recover
  • CPU temp reported is always 0

Additional info

This specifically affects the PECI-over-eSPI implementation (CONFIG_PECI_OVER_ESPI=y).

Acknowledging the completion in #368 fixed it from hanging on shutdown.

Presumably, this could happen because of

  • invalid/insufficient checks in peci_available()
  • missing the check to see if a transaction is currently in progress in peci_get_temp()
  • an issue specifically with eSPI usage?

Blocks: #370

@crawfxrd crawfxrd changed the title oryp11: Unplugging display from TBT port causes PECI timeout peci: Unplugging display from TBT port causes GetTemp() timeouts Jun 21, 2023
@crawfxrd crawfxrd marked this as a duplicate of #525 Apr 10, 2025
@crawfxrd
Copy link
Member Author

PECI over eSPI is now used by

  • addw4
  • lemp13
  • lemp13-b
  • oryp11
  • oryp12

While GetTemp is the most likely PECI call to fail, #525 shows that WrPkgConfig also can fail because of this.

@crawfxrd crawfxrd changed the title peci: Unplugging display from TBT port causes GetTemp() timeouts peci: Unplugging display from TBT port causes command timeouts Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant