Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ShareWindow accessibility label is "Recent searches" #1697

Open
loicteixeira opened this issue May 29, 2024 · 0 comments
Open

ShareWindow accessibility label is "Recent searches" #1697

loicteixeira opened this issue May 29, 2024 · 0 comments
Assignees
@stolinski
Labels
A11y

Comments

@loicteixeira
Copy link

Looking at your ShareWindow component shared (ah!) on episode 775, I noticed it has aria-labelledby="search-header" which doesn't seem to be related.

I imagine it might be correct in some context, but I reckon it isn't when you share an episode:
syntaxfm_sharemodal_labellyby

Thanks for all the amazing podcasts 🌟
@stolinski stolinski self-assigned this Jun 27, 2024
@stolinski stolinski added the A11y label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stolinski stolinski

Labels
A11y
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stolinski @loicteixeira