Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in reportCount func while flushing counter metrics #5

Closed
srikar-jilugu opened this issue May 27, 2024 · 2 comments · Fixed by #6
Closed

Bug in reportCount func while flushing counter metrics #5

srikar-jilugu opened this issue May 27, 2024 · 2 comments · Fixed by #6
Labels

Comments

@srikar-jilugu
Copy link
Contributor

here using name as the key for storing previous values of the metric, leading to corrupted value for metrics of the same name but having different tags.

r.ss[name] = value

Expected Behaviour
value of metric with {name,tags} pair should be independent of each other.

Current Behaviour
last updated value of one metric with the same name is effecting the updated count value of others.

last := r.ss[name]

@syntaqx
Copy link
Owner

syntaqx commented Jul 2, 2024

Sorry for the late response, this project has been mostly in an ice box for me. You're welcome to send a pull request for the patch!

@srikar-jilugu
Copy link
Contributor Author

hey thanks for responding, raised a PR for the fix.

@syntaqx syntaqx closed this as completed in #6 Jul 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants