[Bug]: Restored wallet splits Boosted CPFP transactions into separate activities #1844
Comments
catch-21
added
bug
|
@catch-21 It's what's on the current version of Figma, right? |
|
I assume Figma is correct, in that multiple transactions are to always be grouped into a single activity. |
|
It's about intention. Bitkit loses that intent when we restore because it doesn't back up which transactions were boosted vs transactions that were sent-to-self. They are effectively the same thing, we just bundle boosted transactions together. Potential solution. If we wanted to retain that intent and have boosted transactions bundled together on restore we would have to add boosted transactions to our backup flow and adjust the activity list UI accordingly during restore. Personally, I'm against using backups for anything that is non-critical or UI-related as it adds a lot of complexity and increases the calls we need to make when reading/writing from backups. Therefore, I would argue that keeping the way it currently restores is an acceptable fallback instead of additional complexity. |
|
Draft PR here: #2128 There is currently an issue with restoring boosted transactions, onchain activity is restored before boosted transactions are in state. Will revisit after RBF is implemented. |
|
Tested in release-v1.0.7 3b9a833 |
Describe the bug
When boosting a transaction, the existing activity is updated to reflect the change and combines the subtracted amounts. If the wallet is restored the transactions are displayed as separate activities. We should aim to keep the activity list constant after wallet restore.
Reproduce
Screenshots / Recording
In the following example, the final transaction in the CPFP chain is d69eeb99e9a562e7b9a6a34abce3c77808e4e0f8a077058ee1558881ae209a2b
Before restore, two activities are shown for a chain of three transactions. The top one had a boost and so combines two CPFP transactions and the bottom is a single transaction:
After restore there are three activities, one for each transaction in the CPFP chain:
Operating system
Android 13 TKQ1.221114.001
Bitkit version
4980b42
Log output
No response
The text was updated successfully, but these errors were encountered: