Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: Add ability to switch between sending from savings & spending (unified QR) #2003

Closed
3 tasks done
pwltr opened this issue Jun 19, 2024 · 1 comment · Fixed by #2324
Closed
3 tasks done
Assignees
Labels
enhancement New feature or request estimate:13 feature request A user has an idea for the app

Comments

@pwltr
Copy link
Collaborator

pwltr commented Jun 19, 2024

Describe the problem

No way to switch between “Savings” and “Spending” after scanning a unified QR code

Describe the solution

  • Balance Toggle Functionality: It would be nice to allow the sender to switch between “Savings” and “Spending” after scanning a unified QR code (see mockup video)

  • Fixed States for Toggle:

    • For On-chain-only QR codes, the toggle will be set to a fixed “Savings” state (see mockup video).
    • For Lightning-only invoices, the toggle will be set to a fixed “Spending” state.

  • Max amount: Added max amount modal with short explanation for end user for when ‘max’ amount is tapped in spending balance send flow. https://synonymworkspace.slack.com/archives/C01H106JRQB/p1712855096363569?thread_ts=1712850323.807499&cid=C01H106JRQB

Additional context

No response

@pwltr pwltr added enhancement New feature or request feature request A user has an idea for the app labels Jun 19, 2024
@pwltr pwltr self-assigned this Jun 19, 2024
@JeanlChristophe JeanlChristophe mentioned this issue Sep 3, 2024
36 tasks
@pwltr pwltr changed the title [Feature]: Send to Contact (unified QR) [Feature]: Add ability to switch between sending from savings & spending (unified QR) Sep 16, 2024
@catch-21
Copy link
Contributor

Tested on v1.0.7 and v1.0.8
Toggles show correctly and work well. Static labels show when they should for onchain address and LN invoiced.
It would be nice to also show the label for lnurl, rraised #2413
Tapping the available balance to apply max value shows an orange "Reserve Balance" toast message that reads "The maximum spendable amount is a bit lower due to a required reserve balance."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request estimate:13 feature request A user has an idea for the app
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants