Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Package with the name 'tests' in the name are always ignored? #59

Open
pjordaan opened this issue Sep 11, 2023 · 0 comments
Open

Package with the name 'tests' in the name are always ignored? #59

pjordaan opened this issue Sep 11, 2023 · 0 comments

Comments

@pjordaan
Copy link

Hi,
I have a monorepo and I added a package with classes that are used for writing integration tests much more easily. However, it seems symplify/monorepo-builder was ignoring this package because the name contained the string 'tests' in it.

If I look in the source code I see a hardcoded if statement in PackageComposerFinder that is probably the culprit.
https://github.com/symplify/monorepo-builder/blob/main/src/Finder/PackageComposerFinder.php#L82

Shouldn't this be at least configurable? It could be the default for the path exclude or maybe a test path exclude config?

It's not high priority to fix as I will fix it by just renaming the package for now.

@pjordaan pjordaan changed the title Package with the name tests in the name are always ignored? Package with the name 'tests' in the name are always ignored? Sep 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant