From 1a591e18c64e7367b243729a43a70c2e92025468 Mon Sep 17 00:00:00 2001 From: Tomas Votruba Date: Fri, 23 Feb 2024 14:07:31 +0100 Subject: [PATCH] update content only if changed --- .../RemoveUselessDefaultCommentFixer.php | 3 ++- .../Fixture/skip_no_changes.php.inc | 15 +++++++++++++++ .../config/configured_rule.php | 1 - 3 files changed, 17 insertions(+), 2 deletions(-) create mode 100644 tests/Fixer/Commenting/RemoveUselessDefaultCommentFixer/Fixture/skip_no_changes.php.inc diff --git a/src/Fixer/Commenting/RemoveUselessDefaultCommentFixer.php b/src/Fixer/Commenting/RemoveUselessDefaultCommentFixer.php index 9a2e64f6..94fd3e90 100644 --- a/src/Fixer/Commenting/RemoveUselessDefaultCommentFixer.php +++ b/src/Fixer/Commenting/RemoveUselessDefaultCommentFixer.php @@ -63,12 +63,13 @@ public function fix(SplFileInfo $fileInfo, Tokens $tokens): void continue; } + $originalContent = $token->getContent(); $cleanedDocContent = $this->uselessDocBlockCleaner->clearDocTokenContent($token); if ($cleanedDocContent === '') { // remove token $tokens->clearTokenAndMergeSurroundingWhitespace($index); - } else { + } elseif ($cleanedDocContent !== $originalContent) { // update in case of other contents $tokens[$index] = new Token([T_DOC_COMMENT, $cleanedDocContent]); } diff --git a/tests/Fixer/Commenting/RemoveUselessDefaultCommentFixer/Fixture/skip_no_changes.php.inc b/tests/Fixer/Commenting/RemoveUselessDefaultCommentFixer/Fixture/skip_no_changes.php.inc new file mode 100644 index 00000000..baa65467 --- /dev/null +++ b/tests/Fixer/Commenting/RemoveUselessDefaultCommentFixer/Fixture/skip_no_changes.php.inc @@ -0,0 +1,15 @@ +