Add missing dots at the end of exception messages

fabpot · fabpot · commit b7df8ff958e4 · 2020-03-15T10:38:08.000+01:00
diff --git a/Authentication/SimpleAuthenticationHandler.php b/Authentication/SimpleAuthenticationHandler.php
@@ -64,7 +64,7 @@ public function onAuthenticationSuccess(Request $request, TokenInterface $token)
             }
 
             if (null !== $response) {
-                throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null to use the default success handler, or a Response object', \get_class($this->simpleAuthenticator)));
+                throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null to use the default success handler, or a Response object.', \get_class($this->simpleAuthenticator)));
             }
         }
 
@@ -91,7 +91,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio
             }
 
             if (null !== $response) {
-                throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null to use the default failure handler, or a Response object', \get_class($this->simpleAuthenticator)));
+                throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null to use the default failure handler, or a Response object.', \get_class($this->simpleAuthenticator)));
             }
         }
 
diff --git a/Firewall/DigestAuthenticationListener.php b/Firewall/DigestAuthenticationListener.php
@@ -94,7 +94,7 @@ public function handle(GetResponseEvent $event)
             $user = $this->provider->loadUserByUsername($digestAuth->getUsername());
 
             if (null === $user) {
-                throw new AuthenticationServiceException('Digest User provider returned null, which is an interface contract violation');
+                throw new AuthenticationServiceException('Digest User provider returned null, which is an interface contract violation.');
             }
 
             $serverDigestMd5 = $digestAuth->calculateServerDigest($user->getPassword(), $request->getMethod());
@@ -199,11 +199,11 @@ public function getUsername()
     public function validateAndDecode($entryPointKey, $expectedRealm)
     {
         if ($keys = array_diff(['username', 'realm', 'nonce', 'uri', 'response'], array_keys($this->elements))) {
-            throw new BadCredentialsException(sprintf('Missing mandatory digest value; received header "%s" (%s)', $this->header, implode(', ', $keys)));
+            throw new BadCredentialsException(sprintf('Missing mandatory digest value; received header "%s" (%s).', $this->header, implode(', ', $keys)));
         }
 
         if ('auth' === $this->elements['qop'] && !isset($this->elements['nc'], $this->elements['cnonce'])) {
-            throw new BadCredentialsException(sprintf('Missing mandatory digest value; received header "%s"', $this->header));
+            throw new BadCredentialsException(sprintf('Missing mandatory digest value; received header "%s".', $this->header));
         }
 
         if ($expectedRealm !== $this->elements['realm']) {
diff --git a/Firewall/ExceptionListener.php b/Firewall/ExceptionListener.php
@@ -212,7 +212,7 @@ private function startAuthentication(Request $request, AuthenticationException $
         if (!$response instanceof Response) {
             $given = \is_object($response) ? \get_class($response) : \gettype($response);
 
-            throw new \LogicException(sprintf('The %s::start() method must return a Response object (%s returned)', \get_class($this->authenticationEntryPoint), $given));
+            throw new \LogicException(sprintf('The %s::start() method must return a Response object (%s returned).', \get_class($this->authenticationEntryPoint), $given));
         }
 
         return $response;
diff --git a/Firewall/RemoteUserAuthenticationListener.php b/Firewall/RemoteUserAuthenticationListener.php
@@ -41,7 +41,7 @@ public function __construct(TokenStorageInterface $tokenStorage, AuthenticationM
     protected function getPreAuthenticatedData(Request $request)
     {
         if (!$request->server->has($this->userKey)) {
-            throw new BadCredentialsException(sprintf('User key was not found: %s', $this->userKey));
+            throw new BadCredentialsException(sprintf('User key was not found: %s.', $this->userKey));
         }
 
         return [$request->server->get($this->userKey), null];
diff --git a/Firewall/SimpleFormAuthenticationListener.php b/Firewall/SimpleFormAuthenticationListener.php
@@ -54,7 +54,7 @@ class SimpleFormAuthenticationListener extends AbstractAuthenticationListener
     public function __construct(TokenStorageInterface $tokenStorage, AuthenticationManagerInterface $authenticationManager, SessionAuthenticationStrategyInterface $sessionStrategy, HttpUtils $httpUtils, $providerKey, AuthenticationSuccessHandlerInterface $successHandler, AuthenticationFailureHandlerInterface $failureHandler, array $options = [], LoggerInterface $logger = null, EventDispatcherInterface $dispatcher = null, CsrfTokenManagerInterface $csrfTokenManager = null, SimpleFormAuthenticatorInterface $simpleAuthenticator = null)
     {
         if (!$simpleAuthenticator) {
-            throw new \InvalidArgumentException('Missing simple authenticator');
+            throw new \InvalidArgumentException('Missing simple authenticator.');
         }
 
         $this->simpleAuthenticator = $simpleAuthenticator;
diff --git a/Firewall/SimplePreAuthenticationListener.php b/Firewall/SimplePreAuthenticationListener.php
@@ -120,7 +120,7 @@ public function handle(GetResponseEvent $event)
                 if ($response instanceof Response) {
                     $event->setResponse($response);
                 } elseif (null !== $response) {
-                    throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null or a Response object', \get_class($this->simpleAuthenticator)));
+                    throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null or a Response object.', \get_class($this->simpleAuthenticator)));
                 }
             }
 
@@ -132,7 +132,7 @@ public function handle(GetResponseEvent $event)
             if ($response instanceof Response) {
                 $event->setResponse($response);
             } elseif (null !== $response) {
-                throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null or a Response object', \get_class($this->simpleAuthenticator)));
+                throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null or a Response object.', \get_class($this->simpleAuthenticator)));
             }
         }
     }
diff --git a/Firewall/SwitchUserListener.php b/Firewall/SwitchUserListener.php
@@ -100,7 +100,7 @@ public function handle(GetResponseEvent $event)
             try {
                 $this->tokenStorage->setToken($this->attemptSwitchUser($request, $username));
             } catch (AuthenticationException $e) {
-                throw new \LogicException(sprintf('Switch User failed: "%s"', $e->getMessage()));
+                throw new \LogicException(sprintf('Switch User failed: "%s".', $e->getMessage()));
             }
         }
 
diff --git a/Firewall/X509AuthenticationListener.php b/Firewall/X509AuthenticationListener.php
@@ -52,7 +52,7 @@ protected function getPreAuthenticatedData(Request $request)
         }
 
         if (null === $user) {
-            throw new BadCredentialsException(sprintf('SSL credentials not found: %s, %s', $this->userKey, $this->credentialKey));
+            throw new BadCredentialsException(sprintf('SSL credentials not found: %s, %s.', $this->userKey, $this->credentialKey));
         }
 
         return [$user, $request->server->get($this->credentialKey, '')];
diff --git a/RememberMe/AbstractRememberMeServices.php b/RememberMe/AbstractRememberMeServices.php
@@ -265,7 +265,7 @@ protected function encodeCookie(array $cookieParts)
     {
         foreach ($cookieParts as $cookiePart) {
             if (false !== strpos($cookiePart, self::COOKIE_DELIMITER)) {
-                throw new \InvalidArgumentException(sprintf('$cookieParts should not contain the cookie delimiter "%s"', self::COOKIE_DELIMITER));
+                throw new \InvalidArgumentException(sprintf('$cookieParts should not contain the cookie delimiter "%s".', self::COOKIE_DELIMITER));
             }
         }
 
diff --git a/Session/SessionAuthenticationStrategy.php b/Session/SessionAuthenticationStrategy.php
@@ -59,7 +59,7 @@ public function onAuthentication(Request $request, TokenInterface $token)
                 return;
 
             default:
-                throw new \RuntimeException(sprintf('Invalid session authentication strategy "%s"', $this->strategy));
+                throw new \RuntimeException(sprintf('Invalid session authentication strategy "%s".', $this->strategy));
         }
     }
 }
diff --git a/Tests/Firewall/ExceptionListenerTest.php b/Tests/Firewall/ExceptionListenerTest.php
@@ -86,7 +86,7 @@ public function testExceptionWhenEntryPointReturnsBadValue()
         $listener->onKernelException($event);
         // the exception has been replaced by our LogicException
         $this->assertInstanceOf('LogicException', $event->getException());
-        $this->assertStringEndsWith('start() method must return a Response object (string returned)', $event->getException()->getMessage());
+        $this->assertStringEndsWith('start() method must return a Response object (string returned).', $event->getException()->getMessage());
     }
 
     /**

Original file line number	Diff line number	Diff line change
`@@ -64,7 +64,7 @@ public function onAuthenticationSuccess(Request $request, TokenInterface $token)`
`64`	`64`	`}`
`65`	`65`
`66`	`66`	`if (null !== $response) {`
`67`		`- throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null to use the default success handler, or a Response object', \get_class($this->simpleAuthenticator)));`
	`67`	`+ throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null to use the default success handler, or a Response object.', \get_class($this->simpleAuthenticator)));`
`68`	`68`	`}`
`69`	`69`	`}`
`70`	`70`
`@@ -91,7 +91,7 @@ public function onAuthenticationFailure(Request $request, AuthenticationExceptio`
`91`	`91`	`}`
`92`	`92`
`93`	`93`	`if (null !== $response) {`
`94`		`- throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null to use the default failure handler, or a Response object', \get_class($this->simpleAuthenticator)));`
	`94`	`+ throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null to use the default failure handler, or a Response object.', \get_class($this->simpleAuthenticator)));`
`95`	`95`	`}`
`96`	`96`	`}`
`97`	`97`
Original file line number	Diff line number	Diff line change
`@@ -94,7 +94,7 @@ public function handle(GetResponseEvent $event)`
`94`	`94`	`$user = $this->provider->loadUserByUsername($digestAuth->getUsername());`
`95`	`95`
`96`	`96`	`if (null === $user) {`
`97`		`- throw new AuthenticationServiceException('Digest User provider returned null, which is an interface contract violation');`
	`97`	`+ throw new AuthenticationServiceException('Digest User provider returned null, which is an interface contract violation.');`
`98`	`98`	`}`
`99`	`99`
`100`	`100`	`$serverDigestMd5 = $digestAuth->calculateServerDigest($user->getPassword(), $request->getMethod());`
`@@ -199,11 +199,11 @@ public function getUsername()`
`199`	`199`	`public function validateAndDecode($entryPointKey, $expectedRealm)`
`200`	`200`	`{`
`201`	`201`	`if ($keys = array_diff(['username', 'realm', 'nonce', 'uri', 'response'], array_keys($this->elements))) {`
`202`		`- throw new BadCredentialsException(sprintf('Missing mandatory digest value; received header "%s" (%s)', $this->header, implode(', ', $keys)));`
	`202`	`+ throw new BadCredentialsException(sprintf('Missing mandatory digest value; received header "%s" (%s).', $this->header, implode(', ', $keys)));`
`203`	`203`	`}`
`204`	`204`
`205`	`205`	`if ('auth' === $this->elements['qop'] && !isset($this->elements['nc'], $this->elements['cnonce'])) {`
`206`		`- throw new BadCredentialsException(sprintf('Missing mandatory digest value; received header "%s"', $this->header));`
	`206`	`+ throw new BadCredentialsException(sprintf('Missing mandatory digest value; received header "%s".', $this->header));`
`207`	`207`	`}`
`208`	`208`
`209`	`209`	`if ($expectedRealm !== $this->elements['realm']) {`
Original file line number	Diff line number	Diff line change
`@@ -212,7 +212,7 @@ private function startAuthentication(Request $request, AuthenticationException $`
`212`	`212`	`if (!$response instanceof Response) {`
`213`	`213`	`$given = \is_object($response) ? \get_class($response) : \gettype($response);`
`214`	`214`
`215`		`- throw new \LogicException(sprintf('The %s::start() method must return a Response object (%s returned)', \get_class($this->authenticationEntryPoint), $given));`
	`215`	`+ throw new \LogicException(sprintf('The %s::start() method must return a Response object (%s returned).', \get_class($this->authenticationEntryPoint), $given));`
`216`	`216`	`}`
`217`	`217`
`218`	`218`	`return $response;`
Original file line number	Diff line number	Diff line change
`@@ -41,7 +41,7 @@ public function __construct(TokenStorageInterface $tokenStorage, AuthenticationM`
`41`	`41`	`protected function getPreAuthenticatedData(Request $request)`
`42`	`42`	`{`
`43`	`43`	`if (!$request->server->has($this->userKey)) {`
`44`		`- throw new BadCredentialsException(sprintf('User key was not found: %s', $this->userKey));`
	`44`	`+ throw new BadCredentialsException(sprintf('User key was not found: %s.', $this->userKey));`
`45`	`45`	`}`
`46`	`46`
`47`	`47`	`return [$request->server->get($this->userKey), null];`
Original file line number	Diff line number	Diff line change
`@@ -54,7 +54,7 @@ class SimpleFormAuthenticationListener extends AbstractAuthenticationListener`
`54`	`54`	public function __construct(TokenStorageInterface $tokenStorage, AuthenticationManagerInterface $authenticationManager, SessionAuthenticationStrategyInterface $sessionStrategy, HttpUtils $httpUtils, $providerKey, AuthenticationSuccessHandlerInterface $successHandler, AuthenticationFailureHandlerInterface $failureHandler, array $options = [], LoggerInterface $logger = null, EventDispatcherInterface $dispatcher = null, CsrfTokenManagerInterface $csrfTokenManager = null, SimpleFormAuthenticatorInterface $simpleAuthenticator = null)
`55`	`55`	`{`
`56`	`56`	`if (!$simpleAuthenticator) {`
`57`		`- throw new \InvalidArgumentException('Missing simple authenticator');`
	`57`	`+ throw new \InvalidArgumentException('Missing simple authenticator.');`
`58`	`58`	`}`
`59`	`59`
`60`	`60`	`$this->simpleAuthenticator = $simpleAuthenticator;`
Original file line number	Diff line number	Diff line change
`@@ -120,7 +120,7 @@ public function handle(GetResponseEvent $event)`
`120`	`120`	`if ($response instanceof Response) {`
`121`	`121`	`$event->setResponse($response);`
`122`	`122`	`} elseif (null !== $response) {`
`123`		`- throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null or a Response object', \get_class($this->simpleAuthenticator)));`
	`123`	`+ throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationFailure method must return null or a Response object.', \get_class($this->simpleAuthenticator)));`
`124`	`124`	`}`
`125`	`125`	`}`
`126`	`126`
`@@ -132,7 +132,7 @@ public function handle(GetResponseEvent $event)`
`132`	`132`	`if ($response instanceof Response) {`
`133`	`133`	`$event->setResponse($response);`
`134`	`134`	`} elseif (null !== $response) {`
`135`		`- throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null or a Response object', \get_class($this->simpleAuthenticator)));`
	`135`	`+ throw new \UnexpectedValueException(sprintf('The %s::onAuthenticationSuccess method must return null or a Response object.', \get_class($this->simpleAuthenticator)));`
`136`	`136`	`}`
`137`	`137`	`}`
`138`	`138`	`}`
Original file line number	Diff line number	Diff line change
`@@ -100,7 +100,7 @@ public function handle(GetResponseEvent $event)`
`100`	`100`	`try {`
`101`	`101`	`$this->tokenStorage->setToken($this->attemptSwitchUser($request, $username));`
`102`	`102`	`} catch (AuthenticationException $e) {`
`103`		`- throw new \LogicException(sprintf('Switch User failed: "%s"', $e->getMessage()));`
	`103`	`+ throw new \LogicException(sprintf('Switch User failed: "%s".', $e->getMessage()));`
`104`	`104`	`}`
`105`	`105`	`}`
`106`	`106`
Original file line number	Diff line number	Diff line change
`@@ -52,7 +52,7 @@ protected function getPreAuthenticatedData(Request $request)`
`52`	`52`	`}`
`53`	`53`
`54`	`54`	`if (null === $user) {`
`55`		`- throw new BadCredentialsException(sprintf('SSL credentials not found: %s, %s', $this->userKey, $this->credentialKey));`
	`55`	`+ throw new BadCredentialsException(sprintf('SSL credentials not found: %s, %s.', $this->userKey, $this->credentialKey));`
`56`	`56`	`}`
`57`	`57`
`58`	`58`	`return [$user, $request->server->get($this->credentialKey, '')];`
Original file line number	Diff line number	Diff line change
`@@ -265,7 +265,7 @@ protected function encodeCookie(array $cookieParts)`
`265`	`265`	`{`
`266`	`266`	`foreach ($cookieParts as $cookiePart) {`
`267`	`267`	`if (false !== strpos($cookiePart, self::COOKIE_DELIMITER)) {`
`268`		`- throw new \InvalidArgumentException(sprintf('$cookieParts should not contain the cookie delimiter "%s"', self::COOKIE_DELIMITER));`
	`268`	`+ throw new \InvalidArgumentException(sprintf('$cookieParts should not contain the cookie delimiter "%s".', self::COOKIE_DELIMITER));`
`269`	`269`	`}`
`270`	`270`	`}`
`271`	`271`
Original file line number	Diff line number	Diff line change
`@@ -59,7 +59,7 @@ public function onAuthentication(Request $request, TokenInterface $token)`
`59`	`59`	`return;`
`60`	`60`
`61`	`61`	`default:`
`62`		`- throw new \RuntimeException(sprintf('Invalid session authentication strategy "%s"', $this->strategy));`
	`62`	`+ throw new \RuntimeException(sprintf('Invalid session authentication strategy "%s".', $this->strategy));`
`63`	`63`	`}`
`64`	`64`	`}`
`65`	`65`	`}`