[Security] add return types

nicolas-grekas · nicolas-grekas · commit 8da9fc1098df · 2021-08-20T12:20:32.000+02:00
diff --git a/AccessMap.php b/AccessMap.php
@@ -36,7 +36,7 @@ public function add(RequestMatcherInterface $requestMatcher, array $attributes =
     /**
      * {@inheritdoc}
      */
-    public function getPatterns(Request $request)
+    public function getPatterns(Request $request): array
     {
         foreach ($this->map as $elements) {
             if (null === $elements[0] || $elements[0]->matches($request)) {
diff --git a/AccessMapInterface.php b/AccessMapInterface.php
@@ -27,5 +27,5 @@ interface AccessMapInterface
      *
      * @return array{0: array|null, 1: string|null} A tuple of security attributes and the required channel
      */
-    public function getPatterns(Request $request);
+    public function getPatterns(Request $request): array;
 }
diff --git a/Authentication/AuthenticationFailureHandlerInterface.php b/Authentication/AuthenticationFailureHandlerInterface.php
@@ -30,8 +30,6 @@ interface AuthenticationFailureHandlerInterface
      * This is called when an interactive authentication attempt fails. This is
      * called by authentication listeners inheriting from
      * AbstractAuthenticationListener.
-     *
-     * @return Response
      */
-    public function onAuthenticationFailure(Request $request, AuthenticationException $exception);
+    public function onAuthenticationFailure(Request $request, AuthenticationException $exception): Response;
 }
diff --git a/Authentication/AuthenticationSuccessHandlerInterface.php b/Authentication/AuthenticationSuccessHandlerInterface.php
@@ -30,8 +30,6 @@ interface AuthenticationSuccessHandlerInterface
      * This is called when an interactive authentication attempt succeeds. This
      * is called by authentication listeners inheriting from
      * AbstractAuthenticationListener.
-     *
-     * @return Response
      */
-    public function onAuthenticationSuccess(Request $request, TokenInterface $token);
+    public function onAuthenticationSuccess(Request $request, TokenInterface $token): Response;
 }
diff --git a/Authentication/AuthenticationUtils.php b/Authentication/AuthenticationUtils.php
@@ -30,10 +30,7 @@ public function __construct(RequestStack $requestStack)
         $this->requestStack = $requestStack;
     }
 
-    /**
-     * @return AuthenticationException|null
-     */
-    public function getLastAuthenticationError(bool $clearSession = true)
+    public function getLastAuthenticationError(bool $clearSession = true): ?AuthenticationException
     {
         $request = $this->getRequest();
         $authenticationException = null;
@@ -51,10 +48,7 @@ public function getLastAuthenticationError(bool $clearSession = true)
         return $authenticationException;
     }
 
-    /**
-     * @return string
-     */
-    public function getLastUsername()
+    public function getLastUsername(): string
     {
         $request = $this->getRequest();
 
diff --git a/Authentication/CustomAuthenticationFailureHandler.php b/Authentication/CustomAuthenticationFailureHandler.php
@@ -12,6 +12,7 @@
 namespace Symfony\Component\Security\Http\Authentication;
 
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Security\Core\Exception\AuthenticationException;
 
 /**
@@ -35,7 +36,7 @@ public function __construct(AuthenticationFailureHandlerInterface $handler, arra
     /**
      * {@inheritdoc}
      */
-    public function onAuthenticationFailure(Request $request, AuthenticationException $exception)
+    public function onAuthenticationFailure(Request $request, AuthenticationException $exception): Response
     {
         return $this->handler->onAuthenticationFailure($request, $exception);
     }
diff --git a/Authentication/CustomAuthenticationSuccessHandler.php b/Authentication/CustomAuthenticationSuccessHandler.php
@@ -12,6 +12,7 @@
 namespace Symfony\Component\Security\Http\Authentication;
 
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 
 /**
@@ -39,7 +40,7 @@ public function __construct(AuthenticationSuccessHandlerInterface $handler, arra
     /**
      * {@inheritdoc}
      */
-    public function onAuthenticationSuccess(Request $request, TokenInterface $token)
+    public function onAuthenticationSuccess(Request $request, TokenInterface $token): Response
     {
         return $this->handler->onAuthenticationSuccess($request, $token);
     }
diff --git a/Authentication/DefaultAuthenticationFailureHandler.php b/Authentication/DefaultAuthenticationFailureHandler.php
@@ -13,6 +13,7 @@
 
 use Psr\Log\LoggerInterface;
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\HttpKernelInterface;
 use Symfony\Component\Security\Core\Exception\AuthenticationException;
 use Symfony\Component\Security\Core\Security;
@@ -52,10 +53,8 @@ public function __construct(HttpKernelInterface $httpKernel, HttpUtils $httpUtil
 
     /**
      * Gets the options.
-     *
-     * @return array
      */
-    public function getOptions()
+    public function getOptions(): array
     {
         return $this->options;
     }
@@ -68,7 +67,7 @@ public function setOptions(array $options)
     /**
      * {@inheritdoc}
      */
-    public function onAuthenticationFailure(Request $request, AuthenticationException $exception)
+    public function onAuthenticationFailure(Request $request, AuthenticationException $exception): Response
     {
         if ($failureUrl = ParameterBagUtils::getRequestParameterValue($request, $this->options['failure_path_parameter'])) {
             $this->options['failure_path'] = $failureUrl;
diff --git a/Authentication/DefaultAuthenticationSuccessHandler.php b/Authentication/DefaultAuthenticationSuccessHandler.php
@@ -12,6 +12,7 @@
 namespace Symfony\Component\Security\Http\Authentication;
 
 use Symfony\Component\HttpFoundation\Request;
+use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
 use Symfony\Component\Security\Http\HttpUtils;
 use Symfony\Component\Security\Http\ParameterBagUtils;
@@ -51,17 +52,15 @@ public function __construct(HttpUtils $httpUtils, array $options = [])
     /**
      * {@inheritdoc}
      */
-    public function onAuthenticationSuccess(Request $request, TokenInterface $token)
+    public function onAuthenticationSuccess(Request $request, TokenInterface $token): Response
     {
         return $this->httpUtils->createRedirectResponse($request, $this->determineTargetUrl($request));
     }
 
     /**
      * Gets the options.
-     *
-     * @return array
      */
-    public function getOptions()
+    public function getOptions(): array
     {
         return $this->options;
     }
@@ -83,10 +82,8 @@ public function setFirewallName(string $firewallName): void
 
     /**
      * Builds the target URL according to the defined options.
-     *
-     * @return string
      */
-    protected function determineTargetUrl(Request $request)
+    protected function determineTargetUrl(Request $request): string
     {
         if ($this->options['always_use_default_target_path']) {
             return $this->options['default_target_path'];
diff --git a/Authenticator/AbstractAuthenticator.php b/Authenticator/AbstractAuthenticator.php
@@ -12,7 +12,6 @@
 namespace Symfony\Component\Security\Http\Authenticator;
 
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
-use Symfony\Component\Security\Core\Exception\LogicException;
 use Symfony\Component\Security\Http\Authenticator\Passport\Passport;
 use Symfony\Component\Security\Http\Authenticator\Token\PostAuthenticationToken;
 
diff --git a/Authenticator/Passport/Badge/RememberMeBadge.php b/Authenticator/Passport/Badge/RememberMeBadge.php
@@ -37,7 +37,7 @@ class RememberMeBadge implements BadgeInterface
      *
      * @return $this
      */
-    public function enable(): self
+    public function enable(): static
     {
         $this->enabled = true;
 
@@ -52,7 +52,7 @@ public function enable(): self
      *
      * @return $this
      */
-    public function disable(): self
+    public function disable(): static
     {
         $this->enabled = false;
 
diff --git a/Authenticator/Passport/Passport.php b/Authenticator/Passport/Passport.php
@@ -42,9 +42,6 @@ public function __construct(UserBadge $userBadge, CredentialsInterface $credenti
         }
     }
 
-    /**
-     * {@inheritdoc}
-     */
     public function getUser(): UserInterface
     {
         if (null === $this->user) {
@@ -88,10 +85,7 @@ public function setAttribute(string $name, mixed $value): void
         $this->attributes[$name] = $value;
     }
 
-    /**
-     * @return mixed
-     */
-    public function getAttribute(string $name, mixed $default = null)
+    public function getAttribute(string $name, mixed $default = null): mixed
     {
         return $this->attributes[$name] ?? $default;
     }
diff --git a/Authenticator/Token/PostAuthenticationToken.php b/Authenticator/Token/PostAuthenticationToken.php
@@ -47,7 +47,7 @@ public function __construct(UserInterface $user, string $firewallName, array $ro
      *
      * {@inheritdoc}
      */
-    public function getCredentials()
+    public function getCredentials(): mixed
     {
         return [];
     }
diff --git a/Authorization/AccessDeniedHandlerInterface.php b/Authorization/AccessDeniedHandlerInterface.php
@@ -25,8 +25,6 @@ interface AccessDeniedHandlerInterface
 {
     /**
      * Handles an access denied failure.
-     *
-     * @return Response|null
      */
-    public function handle(Request $request, AccessDeniedException $accessDeniedException);
+    public function handle(Request $request, AccessDeniedException $accessDeniedException): ?Response;
 }
diff --git a/Event/LoginSuccessEvent.php b/Event/LoginSuccessEvent.php
@@ -14,7 +14,6 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
-use Symfony\Component\Security\Core\Exception\LogicException;
 use Symfony\Component\Security\Core\User\UserInterface;
 use Symfony\Component\Security\Http\Authenticator\AuthenticatorInterface;
 use Symfony\Component\Security\Http\Authenticator\Passport\Passport;
diff --git a/Firewall/AccessListener.php b/Firewall/AccessListener.php
@@ -13,15 +13,12 @@
 
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpKernel\Event\RequestEvent;
-use Symfony\Component\Security\Core\Authentication\AuthenticationManagerInterface;
 use Symfony\Component\Security\Core\Authentication\Token\NullToken;
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorageInterface;
 use Symfony\Component\Security\Core\Authorization\AccessDecisionManagerInterface;
 use Symfony\Component\Security\Core\Authorization\Voter\AuthenticatedVoter;
 use Symfony\Component\Security\Core\Exception\AccessDeniedException;
-use Symfony\Component\Security\Core\Exception\AuthenticationCredentialsNotFoundException;
 use Symfony\Component\Security\Http\AccessMapInterface;
-use Symfony\Component\Security\Http\Authentication\NoopAuthenticationManager;
 use Symfony\Component\Security\Http\Event\LazyResponseEvent;
 
 /**
diff --git a/Firewall/ChannelListener.php b/Firewall/ChannelListener.php
@@ -16,7 +16,6 @@
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpKernel\Event\RequestEvent;
 use Symfony\Component\Security\Http\AccessMapInterface;
-use Symfony\Component\Security\Http\EntryPoint\AuthenticationEntryPointInterface;
 
 /**
  * ChannelListener switches the HTTP protocol based on the access control
diff --git a/Firewall/ContextListener.php b/Firewall/ContextListener.php
@@ -29,7 +29,6 @@
 use Symfony\Component\Security\Core\User\PasswordAuthenticatedUserInterface;
 use Symfony\Component\Security\Core\User\UserInterface;
 use Symfony\Component\Security\Core\User\UserProviderInterface;
-use Symfony\Component\Security\Http\Event\DeauthenticatedEvent;
 use Symfony\Component\Security\Http\Event\TokenDeauthenticatedEvent;
 use Symfony\Contracts\EventDispatcher\EventDispatcherInterface;
 
@@ -299,9 +298,6 @@ private function safelyUnserialize(string $serializedToken)
         return $token;
     }
 
-    /**
-     * @param UserInterface $originalUser
-     */
     private static function hasUserChanged(UserInterface $originalUser, TokenInterface $refreshedToken): bool
     {
         $refreshedUser = $refreshedToken->getUser();
diff --git a/FirewallMap.php b/FirewallMap.php
@@ -34,7 +34,7 @@ public function add(RequestMatcherInterface $requestMatcher = null, array $liste
     /**
      * {@inheritdoc}
      */
-    public function getListeners(Request $request)
+    public function getListeners(Request $request): array
     {
         foreach ($this->map as $elements) {
             if (null === $elements[0] || $elements[0]->matches($request)) {
diff --git a/HttpUtils.php b/HttpUtils.php
@@ -51,10 +51,8 @@ public function __construct(UrlGeneratorInterface $urlGenerator = null, UrlMatch
      *
      * @param string $path   A path (an absolute path (/foo), an absolute URL (http://...), or a route name (foo))
      * @param int    $status The status code
-     *
-     * @return RedirectResponse
      */
-    public function createRedirectResponse(Request $request, string $path, int $status = 302)
+    public function createRedirectResponse(Request $request, string $path, int $status = 302): RedirectResponse
     {
         if (null !== $this->secureDomainRegexp && 'https' === $this->urlMatcher->getContext()->getScheme() && preg_match('#^https?:[/\\\\]{2,}+[^/]++#i', $path, $host) && !preg_match(sprintf($this->secureDomainRegexp, preg_quote($request->getHttpHost())), $host[0])) {
             $path = '/';
@@ -70,10 +68,8 @@ public function createRedirectResponse(Request $request, string $path, int $stat
      * Creates a Request.
      *
      * @param string $path A path (an absolute path (/foo), an absolute URL (http://...), or a route name (foo))
-     *
-     * @return Request
      */
-    public function createRequest(Request $request, string $path)
+    public function createRequest(Request $request, string $path): Request
     {
         $newRequest = Request::create($this->generateUri($request, $path), 'get', [], $request->cookies->all(), [], $request->server->all());
 
@@ -111,7 +107,7 @@ public function createRequest(Request $request, string $path)
      *
      * @return bool true if the path is the same as the one from the Request, false otherwise
      */
-    public function checkRequestPath(Request $request, string $path)
+    public function checkRequestPath(Request $request, string $path): bool
     {
         if ('/' !== $path[0]) {
             try {
@@ -138,11 +134,9 @@ public function checkRequestPath(Request $request, string $path)
      *
      * @param string $path A path (an absolute path (/foo), an absolute URL (http://...), or a route name (foo))
      *
-     * @return string
-     *
      * @throws \LogicException
      */
-    public function generateUri(Request $request, string $path)
+    public function generateUri(Request $request, string $path): string
     {
         if (str_starts_with($path, 'http') || !$path) {
             return $path;
diff --git a/LoginLink/Exception/InvalidLoginLinkAuthenticationException.php b/LoginLink/Exception/InvalidLoginLinkAuthenticationException.php
@@ -23,7 +23,7 @@ class InvalidLoginLinkAuthenticationException extends AuthenticationException
     /**
      * {@inheritdoc}
      */
-    public function getMessageKey()
+    public function getMessageKey(): string
     {
         return 'Invalid or expired login link.';
     }
diff --git a/Logout/LogoutUrlGenerator.php b/Logout/LogoutUrlGenerator.php
@@ -53,20 +53,16 @@ public function registerListener(string $key, string $logoutPath, ?string $csrfT
 
     /**
      * Generates the absolute logout path for the firewall.
-     *
-     * @return string
      */
-    public function getLogoutPath(string $key = null)
+    public function getLogoutPath(string $key = null): string
     {
         return $this->generateLogoutUrl($key, UrlGeneratorInterface::ABSOLUTE_PATH);
     }
 
     /**
      * Generates the absolute logout URL for the firewall.
-     *
-     * @return string
      */
-    public function getLogoutUrl(string $key = null)
+    public function getLogoutUrl(string $key = null): string
     {
         return $this->generateLogoutUrl($key, UrlGeneratorInterface::ABSOLUTE_URL);
     }
diff --git a/Tests/Authentication/DefaultAuthenticationFailureHandlerTest.php b/Tests/Authentication/DefaultAuthenticationFailureHandlerTest.php
diff --git a/Tests/EventListener/UserCheckerListenerTest.php b/Tests/EventListener/UserCheckerListenerTest.php
diff --git a/Tests/Firewall/AccessListenerTest.php b/Tests/Firewall/AccessListenerTest.php
diff --git a/Tests/Firewall/ChannelListenerTest.php b/Tests/Firewall/ChannelListenerTest.php
diff --git a/Tests/Firewall/ContextListenerTest.php b/Tests/Firewall/ContextListenerTest.php

Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ public function add(RequestMatcherInterface $requestMatcher, array $attributes =`
`36`	`36`	`/**`
`37`	`37`	`* {@inheritdoc}`
`38`	`38`	`*/`
`39`		`- public function getPatterns(Request $request)`
	`39`	`+ public function getPatterns(Request $request): array`
`40`	`40`	`{`
`41`	`41`	`foreach ($this->map as $elements) {`
`42`	`42`	`if (null === $elements[0] \|\| $elements[0]->matches($request)) {`
Original file line number	Diff line number	Diff line change
`@@ -27,5 +27,5 @@ interface AccessMapInterface`
`27`	`27`	`*`
`28`	`28`	`* @return array{0: array\|null, 1: string\|null} A tuple of security attributes and the required channel`
`29`	`29`	`*/`
`30`		`- public function getPatterns(Request $request);`
	`30`	`+ public function getPatterns(Request $request): array;`
`31`	`31`	`}`
Original file line number	Diff line number	Diff line change
`@@ -30,10 +30,7 @@ public function __construct(RequestStack $requestStack)`
`30`	`30`	`$this->requestStack = $requestStack;`
`31`	`31`	`}`
`32`	`32`
`33`		`- /**`
`34`		`- * @return AuthenticationException\|null`
`35`		`- */`
`36`		`- public function getLastAuthenticationError(bool $clearSession = true)`
	`33`	`+ public function getLastAuthenticationError(bool $clearSession = true): ?AuthenticationException`
`37`	`34`	`{`
`38`	`35`	`$request = $this->getRequest();`
`39`	`36`	`$authenticationException = null;`
`@@ -51,10 +48,7 @@ public function getLastAuthenticationError(bool $clearSession = true)`
`51`	`48`	`return $authenticationException;`
`52`	`49`	`}`
`53`	`50`
`54`		`- /**`
`55`		`- * @return string`
`56`		`- */`
`57`		`- public function getLastUsername()`
	`51`	`+ public function getLastUsername(): string`
`58`	`52`	`{`
`59`	`53`	`$request = $this->getRequest();`
`60`	`54`
Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`namespace Symfony\Component\Security\Http\Authentication;`
`13`	`13`
`14`	`14`	`use Symfony\Component\HttpFoundation\Request;`
	`15`	`+use Symfony\Component\HttpFoundation\Response;`
`15`	`16`	`use Symfony\Component\Security\Core\Exception\AuthenticationException;`
`16`	`17`
`17`	`18`	`/**`
`@@ -35,7 +36,7 @@ public function __construct(AuthenticationFailureHandlerInterface $handler, arra`
`35`	`36`	`/**`
`36`	`37`	`* {@inheritdoc}`
`37`	`38`	`*/`
`38`		`- public function onAuthenticationFailure(Request $request, AuthenticationException $exception)`
	`39`	`+ public function onAuthenticationFailure(Request $request, AuthenticationException $exception): Response`
`39`	`40`	`{`
`40`	`41`	`return $this->handler->onAuthenticationFailure($request, $exception);`
`41`	`42`	`}`
Original file line number	Diff line number	Diff line change
`@@ -37,7 +37,7 @@ class RememberMeBadge implements BadgeInterface`
`37`	`37`	`*`
`38`	`38`	`* @return $this`
`39`	`39`	`*/`
`40`		`- public function enable(): self`
	`40`	`+ public function enable(): static`
`41`	`41`	`{`
`42`	`42`	`$this->enabled = true;`
`43`	`43`
`@@ -52,7 +52,7 @@ public function enable(): self`
`52`	`52`	`*`
`53`	`53`	`* @return $this`
`54`	`54`	`*/`
`55`		`- public function disable(): self`
	`55`	`+ public function disable(): static`
`56`	`56`	`{`
`57`	`57`	`$this->enabled = false;`
`58`	`58`
Original file line number	Diff line number	Diff line change
`@@ -42,9 +42,6 @@ public function __construct(UserBadge $userBadge, CredentialsInterface $credenti`
`42`	`42`	`}`
`43`	`43`	`}`
`44`	`44`
`45`		`- /**`
`46`		`- * {@inheritdoc}`
`47`		`- */`
`48`	`45`	`public function getUser(): UserInterface`
`49`	`46`	`{`
`50`	`47`	`if (null === $this->user) {`
`@@ -88,10 +85,7 @@ public function setAttribute(string $name, mixed $value): void`
`88`	`85`	`$this->attributes[$name] = $value;`
`89`	`86`	`}`
`90`	`87`
`91`		`- /**`
`92`		`- * @return mixed`
`93`		`- */`
`94`		`- public function getAttribute(string $name, mixed $default = null)`
	`88`	`+ public function getAttribute(string $name, mixed $default = null): mixed`
`95`	`89`	`{`
`96`	`90`	`return $this->attributes[$name] ?? $default;`
`97`	`91`	`}`
Original file line number	Diff line number	Diff line change
`@@ -47,7 +47,7 @@ public function __construct(UserInterface $user, string $firewallName, array $ro`
`47`	`47`	`*`
`48`	`48`	`* {@inheritdoc}`
`49`	`49`	`*/`
`50`		`- public function getCredentials()`
	`50`	`+ public function getCredentials(): mixed`
`51`	`51`	`{`
`52`	`52`	`return [];`
`53`	`53`	`}`
Original file line number	Diff line number	Diff line change
`@@ -25,8 +25,6 @@ interface AccessDeniedHandlerInterface`
`25`	`25`	`{`
`26`	`26`	`/**`
`27`	`27`	`* Handles an access denied failure.`
`28`		`- *`
`29`		`- * @return Response\|null`
`30`	`28`	`*/`
`31`		`- public function handle(Request $request, AccessDeniedException $accessDeniedException);`
	`29`	`+ public function handle(Request $request, AccessDeniedException $accessDeniedException): ?Response;`
`32`	`30`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ public function add(RequestMatcherInterface $requestMatcher = null, array $liste`
`34`	`34`	`/**`
`35`	`35`	`* {@inheritdoc}`
`36`	`36`	`*/`
`37`		`- public function getListeners(Request $request)`
	`37`	`+ public function getListeners(Request $request): array`
`38`	`38`	`{`
`39`	`39`	`foreach ($this->map as $elements) {`
`40`	`40`	`if (null === $elements[0] \|\| $elements[0]->matches($request)) {`
Original file line number	Diff line number	Diff line change
`@@ -51,10 +51,8 @@ public function __construct(UrlGeneratorInterface $urlGenerator = null, UrlMatch`
`51`	`51`	`*`
`52`	`52`	`* @param string $path A path (an absolute path (/foo), an absolute URL (http://...), or a route name (foo))`
`53`	`53`	`* @param int $status The status code`
`54`		`- *`
`55`		`- * @return RedirectResponse`
`56`	`54`	`*/`
`57`		`- public function createRedirectResponse(Request $request, string $path, int $status = 302)`
	`55`	`+ public function createRedirectResponse(Request $request, string $path, int $status = 302): RedirectResponse`
`58`	`56`	`{`
`59`	`57`	`if (null !== $this->secureDomainRegexp && 'https' === $this->urlMatcher->getContext()->getScheme() && preg_match('#^https?:[/\\\\]{2,}+[^/]++#i', $path, $host) && !preg_match(sprintf($this->secureDomainRegexp, preg_quote($request->getHttpHost())), $host[0])) {`
`60`	`58`	`$path = '/';`
`@@ -70,10 +68,8 @@ public function createRedirectResponse(Request $request, string $path, int $stat`
`70`	`68`	`* Creates a Request.`
`71`	`69`	`*`
`72`	`70`	`* @param string $path A path (an absolute path (/foo), an absolute URL (http://...), or a route name (foo))`
`73`		`- *`
`74`		`- * @return Request`
`75`	`71`	`*/`
`76`		`- public function createRequest(Request $request, string $path)`
	`72`	`+ public function createRequest(Request $request, string $path): Request`
`77`	`73`	`{`
`78`	`74`	`$newRequest = Request::create($this->generateUri($request, $path), 'get', [], $request->cookies->all(), [], $request->server->all());`
`79`	`75`
`@@ -111,7 +107,7 @@ public function createRequest(Request $request, string $path)`
`111`	`107`	`*`
`112`	`108`	`* @return bool true if the path is the same as the one from the Request, false otherwise`
`113`	`109`	`*/`
`114`		`- public function checkRequestPath(Request $request, string $path)`
	`110`	`+ public function checkRequestPath(Request $request, string $path): bool`
`115`	`111`	`{`
`116`	`112`	`if ('/' !== $path[0]) {`
`117`	`113`	`try {`
`@@ -138,11 +134,9 @@ public function checkRequestPath(Request $request, string $path)`
`138`	`134`	`*`
`139`	`135`	`* @param string $path A path (an absolute path (/foo), an absolute URL (http://...), or a route name (foo))`
`140`	`136`	`*`
`141`		`- * @return string`
`142`		`- *`
`143`	`137`	`* @throws \LogicException`
`144`	`138`	`*/`
`145`		`- public function generateUri(Request $request, string $path)`
	`139`	`+ public function generateUri(Request $request, string $path): string`
`146`	`140`	`{`
`147`	`141`	`if (str_starts_with($path, 'http') \|\| !$path) {`
`148`	`142`	`return $path;`