Merge branch '5.1' into 5.x

Author: derrabus

Response/TraceableResponse.php

@@ -95,6 +95,10 @@ public function getContent(bool $throw = true): string
             if ($this->event && $this->event->isStarted()) {
                 $this->event->stop();
             }
+
+            if ($throw) {
+                $this->checkStatusCode($this->response->getStatusCode());
+            }
         }
     }
 
@@ -116,6 +120,10 @@ public function toArray(bool $throw = true): array
             if ($this->event && $this->event->isStarted()) {
                 $this->event->stop();
             }
+
+            if ($throw) {
+                $this->checkStatusCode($this->response->getStatusCode());
+            }
         }
     }
 

Tests/TraceableHttpClientTest.php

@@ -18,6 +18,7 @@
 use Symfony\Component\HttpClient\Response\MockResponse;
 use Symfony\Component\HttpClient\TraceableHttpClient;
 use Symfony\Component\Stopwatch\Stopwatch;
+use Symfony\Contracts\HttpClient\Exception\ClientExceptionInterface;
 use Symfony\Contracts\HttpClient\HttpClientInterface;
 use Symfony\Contracts\HttpClient\Test\TestHttpServer;
 
@@ -118,6 +119,18 @@ public function testStream()
         $this->assertSame('Symfony is awesome!', implode('', $chunks));
     }
 
+    public function testToArrayChecksStatusCodeBeforeDecoding()
+    {
+        $this->expectException(ClientExceptionInterface::class);
+
+        $sut = new TraceableHttpClient(new MockHttpClient($responseFactory = function (): MockResponse {
+            return new MockResponse('Errored.', ['http_code' => 400]);
+        }));
+
+        $response = $sut->request('GET', 'https://example.com/foo/bar');
+        $response->toArray();
+    }
+
     public function testStopwatch()
     {
         $sw = new Stopwatch(true);