Skip to content

Commit 6a809f3

Browse files
authored
Merge pull request #3 from tucksaun/fix-is-verbose
Fix IsVerbose logic
2 parents ff6b7d1 + d3168fd commit 6a809f3

File tree

2 files changed

+40
-1
lines changed

2 files changed

+40
-1
lines changed

logging.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ func SetLogLevel(level int) error {
4444
}
4545

4646
func IsVerbose() bool {
47-
return Logger.GetLevel() > zerolog.ErrorLevel
47+
return Logger.GetLevel() < zerolog.ErrorLevel
4848
}
4949

5050
func IsDebug() bool {

logging_test.go

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -32,21 +32,60 @@ func (ts *LoggingSuite) TestSetLogLevel(c *C) {
3232
defer SetLogLevel(1)
3333
var err error
3434
c.Assert(Logger.GetLevel(), Equals, zerolog.ErrorLevel)
35+
c.Assert(GetLogLevel(), Equals, 1)
3536

3637
err = SetLogLevel(3)
3738
c.Assert(err, IsNil)
3839
c.Assert(Logger.GetLevel(), Equals, zerolog.InfoLevel)
40+
c.Assert(GetLogLevel(), Equals, 3)
3941

4042
err = SetLogLevel(5)
4143
c.Assert(err, IsNil)
4244
c.Assert(Logger.GetLevel(), Equals, zerolog.TraceLevel)
45+
c.Assert(GetLogLevel(), Equals, 5)
4346

4447
err = SetLogLevel(1)
4548
c.Assert(err, IsNil)
4649
c.Assert(Logger.GetLevel(), Equals, zerolog.ErrorLevel)
50+
c.Assert(GetLogLevel(), Equals, 1)
4751

4852
err = SetLogLevel(9)
4953
c.Assert(err, Not(IsNil))
5054
c.Assert(err.Error(), Equals, "The provided verbosity level '9' is not in the range [1,4]")
5155
c.Assert(Logger.GetLevel(), Equals, zerolog.ErrorLevel)
56+
c.Assert(GetLogLevel(), Equals, 1)
57+
}
58+
59+
func (ts *LoggingSuite) TestIsVerbose(c *C) {
60+
defer SetLogLevel(1)
61+
var err error
62+
63+
c.Assert(IsVerbose(), Equals, false)
64+
65+
err = SetLogLevel(3)
66+
c.Assert(err, IsNil)
67+
c.Assert(IsVerbose(), Equals, true)
68+
69+
err = SetLogLevel(5)
70+
c.Assert(err, IsNil)
71+
c.Assert(IsVerbose(), Equals, true)
72+
}
73+
74+
func (ts *LoggingSuite) TestIsDebug(c *C) {
75+
defer SetLogLevel(1)
76+
var err error
77+
78+
c.Assert(IsDebug(), Equals, false)
79+
80+
err = SetLogLevel(2)
81+
c.Assert(err, IsNil)
82+
c.Assert(IsDebug(), Equals, false)
83+
84+
err = SetLogLevel(3)
85+
c.Assert(err, IsNil)
86+
c.Assert(IsDebug(), Equals, false)
87+
88+
err = SetLogLevel(5)
89+
c.Assert(err, IsNil)
90+
c.Assert(IsDebug(), Equals, true)
5291
}

0 commit comments

Comments
 (0)