Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug]: Null comparisons without type checking #32

Open
1 task done
Biki-das opened this issue Oct 25, 2021 · 2 comments
Open
1 task done

[Bug]: Null comparisons without type checking #32

Biki-das opened this issue Oct 25, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@Biki-das
Copy link

Biki-das commented Oct 25, 2021

Contact Details

No response

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

i found piece of code doing null comparison without type safety,

this is what it looks like
if (installingWorker == null) { return;}
(contentType != null && contentType.indexOf('javascript') === -1)

Expected Behavior

adding type safety will be better
if (installingWorker === null) { return; }
(contentType !== null && contentType.indexOf('javascript') === -1)

Steps To Reproduce

No response

Environment

- OS:
- Node:
- npm:

What browsers are you seeing the problem on?

No response

Anything else?

No response

@Biki-das Biki-das added the bug Something isn't working label Oct 25, 2021
@Biki-das
Copy link
Author

@visharma-symbl could you review this issue and give me some feedback

@Biki-das
Copy link
Author

thanks @Akankshabhasin for assigning

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant