{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":622964494,"defaultBranch":"master","name":"scylla-cqlsh","ownerLogin":"sylwiaszunejko","currentUserCanPush":false,"isFork":true,"isEmpty":false,"createdAt":"2023-04-03T12:26:35.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/52855732?v=4","public":true,"private":false,"isOrgOwned":false},"refInfo":{"name":"","listCacheKey":"v0:1716277351.0","currentOid":""},"activityList":{"items":[{"before":"fdf30963394393c6e2578a2a5beb406531c2b9a4","after":"b3604ad2300217db2291f72714c7a14a1cc9785d","ref":"refs/heads/server_side_describe","pushedAt":"2024-05-27T09:47:45.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"cqlsh: try server-side DESCRIBE, then client-side\n\nSince Scylla 5.2 (https://github.com/scylladb/scylladb/commit/e6ffc220539a05cf7b2a0e37368c27075d809476)\na support for server-side DESCRIBE was added. However, cqlsh did not\nstart to use this functionality, since it is only enabled if it detects\nCQL version at least 4. Scylla did not increase this version number as\nit doesn't support all of its features, so there is a need for a\ndifferent detection mechanism for server-side DESCRIBE.\n\nThis commit changes the behavior in do_describe: cqlsh will first try\nto execute the server-side DESCRIBE. If this fails with SyntaxException,\nmeaning that Scylla doesn't support that command, cqlsh falls back to\nthe client-side DESCRIBE behavior.\n\nThe other possible solutions were rejected:\n- Based on Scylla version: would require ugly hard-coding of versions\n- Modifying Scylla to provide some indication that this feature is\n  enabled: Scylla 5.2 is already released without it, by implementing\n  it in another way, we'll get it out sooner\n- Do a trial \"DESCRIBE\" at the start of connection to detect if the\n  server supports it: if cqlsh ever supported connecting to multiple\n  nodes (right now it uses WhiteListRoundRobinPolicy) we would have\n  to do the check on all of the nodes in case a rolling upgrade is\n  currently occurring and some of the nodes don't support server-side\n  DESCRIBE.\n\nThe change was tested manually on a couple of last Scylla OSS, Scylla\nEnterprise and Cassandra releases.\n\nFixes #17","shortMessageHtmlLink":"cqlsh: try server-side DESCRIBE, then client-side"}},{"before":"01dd212dad10a3b68689ace5b45df3cb67f21c94","after":"fdf30963394393c6e2578a2a5beb406531c2b9a4","ref":"refs/heads/server_side_describe","pushedAt":"2024-05-27T09:36:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"cqlsh: try server-side DESCRIBE, then client-side\n\nSince Scylla 5.2 (https://github.com/scylladb/scylladb/commit/e6ffc220539a05cf7b2a0e37368c27075d809476)\na support for server-side DESCRIBE was added. However, cqlsh did not\nstart to use this functionality, since it is only enabled if it detects\nCQL version at least 4. Scylla did not increase this version number as\nit doesn't support all of its features, so there is a need for a\ndifferent detection mechanism for server-side DESCRIBE.\n\nThis commit changes the behavior in do_describe: cqlsh will first try\nto execute the server-side DESCRIBE. If this fails with SyntaxException,\nmeaning that Scylla doesn't support that command, cqlsh falls back to\nthe client-side DESCRIBE behavior.\n\nThe other possible solutions were rejected:\n- Based on Scylla version: would require ugly hard-coding of versions\n- Modifying Scylla to provide some indication that this feature is\n  enabled: Scylla 5.2 is already released without it, by implementing\n  it in another way, we'll get it out sooner\n- Do a trial \"DESCRIBE\" at the start of connection to detect if the\n  server supports it: if cqlsh ever supported connecting to multiple\n  nodes (right now it uses WhiteListRoundRobinPolicy) we would have\n  to do the check on all of the nodes in case a rolling upgrade is\n  currently occurring and some of the nodes don't support server-side\n  DESCRIBE.\n\nThe change was tested manually on a couple of last Scylla OSS, Scylla\nEnterprise and Cassandra releases.\n\nFixes #17","shortMessageHtmlLink":"cqlsh: try server-side DESCRIBE, then client-side"}},{"before":"3fa2fdda3b11b8ff21b06302de7728f3fdbedc31","after":"01dd212dad10a3b68689ace5b45df3cb67f21c94","ref":"refs/heads/server_side_describe","pushedAt":"2024-05-27T09:22:28.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"cqlsh: try server-side DESCRIBE, then client-side\n\nSince Scylla 5.2 (https://github.com/scylladb/scylladb/commit/e6ffc220539a05cf7b2a0e37368c27075d809476)\na support for server-side DESCRIBE was added. However, cqlsh did not\nstart to use this functionality, since it is only enabled if it detects\nCQL version at least 4. Scylla did not increase this version number as\nit doesn't support all of its features, so there is a need for a\ndifferent detection mechanism for server-side DESCRIBE.\n\nThis commit changes the behavior in do_describe: cqlsh will first try\nto execute the server-side DESCRIBE. If this fails with SyntaxException,\nmeaning that Scylla doesn't support that command, cqlsh falls back to\nthe client-side DESCRIBE behavior.\n\nThe other possible solutions were rejected:\n- Based on Scylla version: would require ugly hard-coding of versions\n- Modifying Scylla to provide some indication that this feature is\n  enabled: Scylla 5.2 is already released without it, by implementing\n  it in another way, we'll get it out sooner\n- Do a trial \"DESCRIBE\" at the start of connection to detect if the\n  server supports it: if cqlsh ever supported connecting to multiple\n  nodes (right now it uses WhiteListRoundRobinPolicy) we would have\n  to do the check on all of the nodes in case a rolling upgrade is\n  currently occurring and some of the nodes don't support server-side\n  DESCRIBE.\n\nThe change was tested manually on a couple of last Scylla OSS, Scylla\nEnterprise and Cassandra releases.\n\nFixes #17","shortMessageHtmlLink":"cqlsh: try server-side DESCRIBE, then client-side"}},{"before":null,"after":"1c26be0b207cd259e87a5250910bc78480f14ef4","ref":"refs/heads/descibe_local2","pushedAt":"2024-05-21T07:42:31.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"temp","shortMessageHtmlLink":"temp"}},{"before":"c5684264bd904b39272a4bac43686014ca4db6dd","after":"b40b14f67f32b3aadc5298669ecbc4d467b75744","ref":"refs/heads/describe_local","pushedAt":"2024-05-20T18:45:54.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"temp","shortMessageHtmlLink":"temp"}},{"before":"d513a2a67765e7ca6d5b843e21723b94eb6ef817","after":"c5684264bd904b39272a4bac43686014ca4db6dd","ref":"refs/heads/describe_local","pushedAt":"2024-05-20T18:25:37.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"temp","shortMessageHtmlLink":"temp"}},{"before":"517e18c06163acf7cae8f83ff76a7e1d75ebbdde","after":"d513a2a67765e7ca6d5b843e21723b94eb6ef817","ref":"refs/heads/describe_local","pushedAt":"2024-05-20T18:13:16.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"temp","shortMessageHtmlLink":"temp"}},{"before":"23441c4e96a1c29e703527218a96e16af18629b3","after":"517e18c06163acf7cae8f83ff76a7e1d75ebbdde","ref":"refs/heads/describe_local","pushedAt":"2024-05-20T17:50:50.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"cqlsh: try server-side DESCRIBE, then client-side\n\nSince Scylla 5.2 (https://github.com/scylladb/scylladb/commit/e6ffc220539a05cf7b2a0e37368c27075d809476)\na support for server-side DESCRIBE was added. However, cqlsh did not\nstart to use this functionality, since it is only enabled if it detects\nCQL version at least 4. Scylla did not increase this version number as\nit doesn't support all of its features, so there is a need for a\ndifferent detection mechanism for server-side DESCRIBE.\n\nThis commit changes the behavior in do_describe: cqlsh will first try\nto execute the server-side DESCRIBE. If this fails with SyntaxException,\nmeaning that Scylla doesn't support that command, cqlsh falls back to\nthe client-side DESCRIBE behavior.\n\nThe other possible solutions were rejected:\n- Based on Scylla version: would require ugly hard-coding of versions\n- Modifying Scylla to provide some indication that this feature is\n  enabled: Scylla 5.2 is already released without it, by implementing\n  it in another way, we'll get it out sooner\n- Do a trial \"DESCRIBE\" at the start of connection to detect if the\n  server supports it: if cqlsh ever supported connecting to multiple\n  nodes (right now it uses WhiteListRoundRobinPolicy) we would have\n  to do the check on all of the nodes in case a rolling upgrade is\n  currently occurring and some of the nodes don't support server-side\n  DESCRIBE.\n\nThe change was tested manually on a couple of last Scylla OSS, Scylla\nEnterprise and Cassandra releases.\n\nFixes #17","shortMessageHtmlLink":"cqlsh: try server-side DESCRIBE, then client-side"}},{"before":"ec14db5f88984009a842b1a2a4b73a75a2473f11","after":"c815855506cc5e091e2861d4eb25ced5453c5c81","ref":"refs/heads/master","pushedAt":"2024-05-20T07:40:40.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"cqlshlib/sslhandling: fix logic of `ssl_check_hostname`\n\nthe logic was broken, and could lead to `AttributeError`,\nlike the following:\n```\nE       AssertionError: Traceback (most recent call last):\nE           File \"/jenkins/workspace/scylla-master/gating-dtest-release/scylla/.ccm/scylla-repository/18591/share/cassandra/libexec/cqlsh.py\", line 2723, in <module>\nE             main(*read_options(sys.argv[1:], os.environ))\nE           File \"/jenkins/workspace/scylla-master/gating-dtest-release/scylla/.ccm/scylla-repository/18591/share/cassandra/libexec/cqlsh.py\", line 2664, in main\nE             shell = Shell(hostname,\nE                     ^^^^^^^^^^^^^^^\nE           File \"/jenkins/workspace/scylla-master/gating-dtest-release/scylla/.ccm/scylla-repository/18591/share/cassandra/libexec/cqlsh.py\", line 495, in __init__\nE             kwargs['ssl_context'] = sslhandling.ssl_settings(hostname, CONFIG_FILE) if ssl else None\nE                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nE           File \"/jenkins/workspace/scylla-master/gating-dtest-release/scylla/.ccm/scylla-repository/18591/share/cassandra/libexec/../pylib/cqlshlib/sslhandling.py\", line 64, in ssl_settings\nE             ssl_check_hostname = ssl_check_hostname is not None or ssl_check_hostname.lower() != 'false'\nE                                                                    ^^^^^^^^^^^^^^^^^^^^^^^^\nE         AttributeError: 'NoneType' object has no attribute 'lower'\n```","shortMessageHtmlLink":"cqlshlib/sslhandling: fix logic of <code>ssl_check_hostname</code>"}},{"before":"3deeacc3a472d31f4922ab3d7ee84956945ac447","after":"3fa2fdda3b11b8ff21b06302de7728f3fdbedc31","ref":"refs/heads/server_side_describe","pushedAt":"2024-05-17T07:03:59.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"cqlsh: try server-side DESCRIBE, then client-side\n\nSince Scylla 5.2 (https://github.com/scylladb/scylladb/commit/e6ffc220539a05cf7b2a0e37368c27075d809476)\na support for server-side DESCRIBE was added. However, cqlsh did not\nstart to use this functionality, since it is only enabled if it detects\nCQL version at least 4. Scylla did not increase this version number as\nit doesn't support all of its features, so there is a need for a\ndifferent detection mechanism for server-side DESCRIBE.\n\nThis commit changes the behavior in do_describe: cqlsh will first try\nto execute the server-side DESCRIBE. If this fails with SyntaxException,\nmeaning that Scylla doesn't support that command, cqlsh falls back to\nthe client-side DESCRIBE behavior.\n\nThe other possible solutions were rejected:\n- Based on Scylla version: would require ugly hard-coding of versions\n- Modifying Scylla to provide some indication that this feature is\n  enabled: Scylla 5.2 is already released without it, by implementing\n  it in another way, we'll get it out sooner\n- Do a trial \"DESCRIBE\" at the start of connection to detect if the\n  server supports it: if cqlsh ever supported connecting to multiple\n  nodes (right now it uses WhiteListRoundRobinPolicy) we would have\n  to do the check on all of the nodes in case a rolling upgrade is\n  currently occurring and some of the nodes don't support server-side\n  DESCRIBE.\n\nThe change was tested manually on a couple of last Scylla OSS, Scylla\nEnterprise and Cassandra releases.\n\nFixes #17","shortMessageHtmlLink":"cqlsh: try server-side DESCRIBE, then client-side"}},{"before":"7c9e942e9413e61d5380b8164b49df680414be4d","after":"3deeacc3a472d31f4922ab3d7ee84956945ac447","ref":"refs/heads/server_side_describe","pushedAt":"2024-05-16T09:31:03.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"cqlsh: try server-side DESCRIBE, then client-side\n\nSince Scylla 5.2 (https://github.com/scylladb/scylladb/commit/e6ffc220539a05cf7b2a0e37368c27075d809476)\na support for server-side DESCRIBE was added. However, cqlsh did not\nstart to use this functionality, since it is only enabled if it detects\nCQL version at least 4. Scylla did not increase this version number as\nit doesn't support all of its features, so there is a need for a\ndifferent detection mechanism for server-side DESCRIBE.\n\nThis commit changes the behavior in do_describe: cqlsh will first try\nto execute the server-side DESCRIBE. If this fails with SyntaxException,\nmeaning that Scylla doesn't support that command, cqlsh falls back to\nthe client-side DESCRIBE behavior.\n\nThe other possible solutions were rejected:\n- Based on Scylla version: would require ugly hard-coding of versions\n- Modifying Scylla to provide some indication that this feature is\n  enabled: Scylla 5.2 is already released without it, by implementing\n  it in another way, we'll get it out sooner\n- Do a trial \"DESCRIBE\" at the start of connection to detect if the\n  server supports it: if cqlsh ever supported connecting to multiple\n  nodes (right now it uses WhiteListRoundRobinPolicy) we would have\n  to do the check on all of the nodes in case a rolling upgrade is\n  currently occurring and some of the nodes don't support server-side\n  DESCRIBE.\n\nThe change was tested manually on a couple of last Scylla OSS, Scylla\nEnterprise and Cassandra releases.\n\nFixes #17","shortMessageHtmlLink":"cqlsh: try server-side DESCRIBE, then client-side"}},{"before":"c815855506cc5e091e2861d4eb25ced5453c5c81","after":"ec14db5f88984009a842b1a2a4b73a75a2473f11","ref":"refs/heads/master","pushedAt":"2024-05-15T12:10:04.000Z","pushType":"pr_merge","commitsCount":3,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"Merge pull request #2 from sylwiaszunejko/server_side_describe\n\nServer side describe","shortMessageHtmlLink":"Merge pull request <a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"2297736266\" data-permission-text=\"Title is private\" data-url=\"https://github.com/sylwiaszunejko/scylla-cqlsh/issues/2\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/sylwiaszunejko/scylla-cqlsh/pull/2/hovercard\" href=\"https://github.com/sylwiaszunejko/scylla-cqlsh/pull/2\">#2</a> from sylwiaszunejko/server_side_describe"}},{"before":"3a0f12bc7f0bf57b3803ee2c0302f6aebf6d06c6","after":"7c9e942e9413e61d5380b8164b49df680414be4d","ref":"refs/heads/server_side_describe","pushedAt":"2024-05-14T11:49:27.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"cqlsh: try server-side DESCRIBE, then client-side\n\nSince Scylla 5.2 (https://github.com/scylladb/scylladb/commit/e6ffc220539a05cf7b2a0e37368c27075d809476)\na support for server-side DESCRIBE was added. However, cqlsh did not\nstart to use this functionality, since it is only enabled if it detects\nCQL version at least 4. Scylla did not increase this version number as\nit doesn't support all of its features, so there is a need for a \ndifferent detection mechanism for server-side DESCRIBE.\n\nThis commit changes the behavior in do_describe: cqlsh will first try\nto execute the server-side DESCRIBE. If this fails with SyntaxException,\nmeaning that Scylla doesn't support that command, cqlsh falls back to\nthe client-side DESCRIBE behavior.\n\nThe other possible solutions were rejected:\n- Based on Scylla version: would require ugly hard-coding of versions\n- Modifying Scylla to provide some indication that this feature is \n  enabled: Scylla 5.2 is already released without it, by implementing\n  it in another way, we'll get it out sooner\n- Do a trial \"DESCRIBE\" at the start of connection to detect if the\n  server supports it: if cqlsh ever supported connecting to multiple\n  nodes (right now it uses WhiteListRoundRobinPolicy) we would have\n  to do the check on all of the nodes in case a rolling upgrade is\n  currently occurring and some of the nodes don't support server-side\n  DESCRIBE.\n\nThe change was tested manually on a couple of last Scylla OSS, Scylla\nEnterprise and Cassandra releases.\n\nFixes #17","shortMessageHtmlLink":"cqlsh: try server-side DESCRIBE, then client-side"}},{"before":"e90fe7f51ea845cf817f0dacf0e2374f60ebe7a9","after":"23441c4e96a1c29e703527218a96e16af18629b3","ref":"refs/heads/describe_local","pushedAt":"2024-05-14T11:37:15.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"Fix tests","shortMessageHtmlLink":"Fix tests"}},{"before":"78abc29f378cde2251fea5bdab6a8b28ec816e1f","after":"e90fe7f51ea845cf817f0dacf0e2374f60ebe7a9","ref":"refs/heads/describe_local","pushedAt":"2024-05-14T11:30:18.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"Fix tests","shortMessageHtmlLink":"Fix tests"}},{"before":"bd20f135277fec2fd7a6831e61c7ebafa0ffc4cb","after":"78abc29f378cde2251fea5bdab6a8b28ec816e1f","ref":"refs/heads/describe_local","pushedAt":"2024-05-14T11:22:33.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"Fix tests","shortMessageHtmlLink":"Fix tests"}},{"before":"3782ca3c4460c00dc50dd1a372920ddb16c5ef5c","after":"bd20f135277fec2fd7a6831e61c7ebafa0ffc4cb","ref":"refs/heads/describe_local","pushedAt":"2024-05-14T11:15:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"Fix tests","shortMessageHtmlLink":"Fix tests"}},{"before":"de86fb16e233461ebab7d6ffd42d99ee7b7e36f1","after":"3782ca3c4460c00dc50dd1a372920ddb16c5ef5c","ref":"refs/heads/describe_local","pushedAt":"2024-05-14T11:09:02.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"Fix tests","shortMessageHtmlLink":"Fix tests"}},{"before":"4f052ba032f0de5543ec11a3443d8f068a9b9a42","after":"de86fb16e233461ebab7d6ffd42d99ee7b7e36f1","ref":"refs/heads/describe_local","pushedAt":"2024-05-14T11:01:39.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"Fix tests","shortMessageHtmlLink":"Fix tests"}},{"before":"0162bec5a41b0ac08b3ba289b572d55a7412b935","after":"4f052ba032f0de5543ec11a3443d8f068a9b9a42","ref":"refs/heads/describe_local","pushedAt":"2024-05-14T10:52:14.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"Fix tests","shortMessageHtmlLink":"Fix tests"}},{"before":"adc449ea46a23b29cd73640e114b981f0f0f11d7","after":"0162bec5a41b0ac08b3ba289b572d55a7412b935","ref":"refs/heads/describe_local","pushedAt":"2024-05-14T10:38:00.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"Fix tests","shortMessageHtmlLink":"Fix tests"}},{"before":"3a0f12bc7f0bf57b3803ee2c0302f6aebf6d06c6","after":"adc449ea46a23b29cd73640e114b981f0f0f11d7","ref":"refs/heads/describe_local","pushedAt":"2024-05-14T10:31:04.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"cqlsh: try server-side DESCRIBE, then client-side\n\nSince Scylla 5.2 (https://github.com/scylladb/scylladb/commit/e6ffc220539a05cf7b2a0e37368c27075d809476)\na support for server-side DESCRIBE was added. However, cqlsh did not\nstart to use this functionality, since it is only enabled if it detects\nCQL version at least 4. Scylla did not increase this version number as\nit doesn't support all of its features, so there is a need for a \ndifferent detection mechanism for server-side DESCRIBE.\n\nThis commit changes the behavior in do_describe: cqlsh will first try\nto execute the server-side DESCRIBE. If this fails with SyntaxException,\nmeaning that Scylla doesn't support that command, cqlsh falls back to\nthe client-side DESCRIBE behavior.\n\nThe other possible solutions were rejected:\n- Based on Scylla version: would require ugly hard-coding of versions\n- Modifying Scylla to provide some indication that this feature is \n  enabled: Scylla 5.2 is already released without it, by implementing\n  it in another way, we'll get it out sooner\n- Do a trial \"DESCRIBE\" at the start of connection to detect if the\n  server supports it: if cqlsh ever supported connecting to multiple\n  nodes (right now it uses WhiteListRoundRobinPolicy) we would have\n  to do the check on all of the nodes in case a rolling upgrade is\n  currently occurring and some of the nodes don't support server-side\n  DESCRIBE.\n\nThe change was tested manually on a couple of last Scylla OSS, Scylla\nEnterprise and Cassandra releases.\n\nFixes #17","shortMessageHtmlLink":"cqlsh: try server-side DESCRIBE, then client-side"}},{"before":null,"after":"3a0f12bc7f0bf57b3803ee2c0302f6aebf6d06c6","ref":"refs/heads/describe_local","pushedAt":"2024-05-14T10:26:25.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"cqlsh: try server-side DESCRIBE, then client-side\n\nSince Scylla 5.2 (https://github.com/scylladb/scylladb/commit/e6ffc220539a05cf7b2a0e37368c27075d809476)\na support for server-side DESCRIBE was added. However, cqlsh did not\nstart to use this functionality, since it is only enabled if it detects\nCQL version at least 4. Scylla did not increase this version number as\nit doesn't support all of its features, so there is a need for a \ndifferent detection mechanism for server-side DESCRIBE.\n\nThis commit changes the behavior in do_describe: cqlsh will first try\nto execute the server-side DESCRIBE. If this fails with SyntaxException,\nmeaning that Scylla doesn't support that command, cqlsh falls back to\nthe client-side DESCRIBE behavior.\n\nThe other possible solutions were rejected:\n- Based on Scylla version: would require ugly hard-coding of versions\n- Modifying Scylla to provide some indication that this feature is \n  enabled: Scylla 5.2 is already released without it, by implementing\n  it in another way, we'll get it out sooner\n- Do a trial \"DESCRIBE\" at the start of connection to detect if the\n  server supports it: if cqlsh ever supported connecting to multiple\n  nodes (right now it uses WhiteListRoundRobinPolicy) we would have\n  to do the check on all of the nodes in case a rolling upgrade is\n  currently occurring and some of the nodes don't support server-side\n  DESCRIBE.\n\nThe change was tested manually on a couple of last Scylla OSS, Scylla\nEnterprise and Cassandra releases.\n\nFixes #17","shortMessageHtmlLink":"cqlsh: try server-side DESCRIBE, then client-side"}},{"before":"bc210b7c3d81668fc01eb732bffa8320aa558729","after":"3a0f12bc7f0bf57b3803ee2c0302f6aebf6d06c6","ref":"refs/heads/server_side_describe","pushedAt":"2024-05-14T10:03:26.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"cqlsh: try server-side DESCRIBE, then client-side\n\nSince Scylla 5.2 (https://github.com/scylladb/scylladb/commit/e6ffc220539a05cf7b2a0e37368c27075d809476)\na support for server-side DESCRIBE was added. However, cqlsh did not\nstart to use this functionality, since it is only enabled if it detects\nCQL version at least 4. Scylla did not increase this version number as\nit doesn't support all of its features, so there is a need for a \ndifferent detection mechanism for server-side DESCRIBE.\n\nThis commit changes the behavior in do_describe: cqlsh will first try\nto execute the server-side DESCRIBE. If this fails with SyntaxException,\nmeaning that Scylla doesn't support that command, cqlsh falls back to\nthe client-side DESCRIBE behavior.\n\nThe other possible solutions were rejected:\n- Based on Scylla version: would require ugly hard-coding of versions\n- Modifying Scylla to provide some indication that this feature is \n  enabled: Scylla 5.2 is already released without it, by implementing\n  it in another way, we'll get it out sooner\n- Do a trial \"DESCRIBE\" at the start of connection to detect if the\n  server supports it: if cqlsh ever supported connecting to multiple\n  nodes (right now it uses WhiteListRoundRobinPolicy) we would have\n  to do the check on all of the nodes in case a rolling upgrade is\n  currently occurring and some of the nodes don't support server-side\n  DESCRIBE.\n\nThe change was tested manually on a couple of last Scylla OSS, Scylla\nEnterprise and Cassandra releases.\n\nFixes #17","shortMessageHtmlLink":"cqlsh: try server-side DESCRIBE, then client-side"}},{"before":null,"after":"bc210b7c3d81668fc01eb732bffa8320aa558729","ref":"refs/heads/server_side_describe","pushedAt":"2024-05-14T10:01:12.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"cqlsh: try server-side DESCRIBE, then client-side\n\nSince Scylla 5.2 (https://github.com/scylladb/scylladb/commit/e6ffc220539a05cf7b2a0e37368c27075d809476)\na support for server-side DESCRIBE was added. However, cqlsh did not\nstart to use this functionality, since it is only enabled if it detects\nCQL version at least 4. Scylla did not increase this version number as\nit doesn't support all of its features, so there is a need for a \ndifferent detection mechanism for server-side DESCRIBE.\n\nThis commit changes the behavior in do_describe: cqlsh will first try\nto execute the server-side DESCRIBE. If this fails with SyntaxException,\nmeaning that Scylla doesn't support that command, cqlsh falls back to\nthe client-side DESCRIBE behavior.\n\nThe other possible solutions were rejected:\n- Based on Scylla version: would require ugly hard-coding of versions\n- Modifying Scylla to provide some indication that this feature is \n  enabled: Scylla 5.2 is already released without it, by implementing\n  it in another way, we'll get it out sooner\n- Do a trial \"DESCRIBE\" at the start of connection to detect if the\n  server supports it: if cqlsh ever supported connecting to multiple\n  nodes (right now it uses WhiteListRoundRobinPolicy) we would have\n  to do the check on all of the nodes in case a rolling upgrade is\n  currently occurring and some of the nodes don't support server-side\n  DESCRIBE.\n\nThe change was tested manually on a couple of last Scylla OSS, Scylla\nEnterprise and Cassandra releases.\n\nFixes #17","shortMessageHtmlLink":"cqlsh: try server-side DESCRIBE, then client-side"}},{"before":"8bd3367e9a77d587a061975df96ac4dccee9683c","after":"c815855506cc5e091e2861d4eb25ced5453c5c81","ref":"refs/heads/master","pushedAt":"2024-05-13T12:41:08.000Z","pushType":"push","commitsCount":15,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"cqlshlib/sslhandling: fix logic of `ssl_check_hostname`\n\nthe logic was broken, and could lead to `AttributeError`,\nlike the following:\n```\nE       AssertionError: Traceback (most recent call last):\nE           File \"/jenkins/workspace/scylla-master/gating-dtest-release/scylla/.ccm/scylla-repository/18591/share/cassandra/libexec/cqlsh.py\", line 2723, in <module>\nE             main(*read_options(sys.argv[1:], os.environ))\nE           File \"/jenkins/workspace/scylla-master/gating-dtest-release/scylla/.ccm/scylla-repository/18591/share/cassandra/libexec/cqlsh.py\", line 2664, in main\nE             shell = Shell(hostname,\nE                     ^^^^^^^^^^^^^^^\nE           File \"/jenkins/workspace/scylla-master/gating-dtest-release/scylla/.ccm/scylla-repository/18591/share/cassandra/libexec/cqlsh.py\", line 495, in __init__\nE             kwargs['ssl_context'] = sslhandling.ssl_settings(hostname, CONFIG_FILE) if ssl else None\nE                                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^\nE           File \"/jenkins/workspace/scylla-master/gating-dtest-release/scylla/.ccm/scylla-repository/18591/share/cassandra/libexec/../pylib/cqlshlib/sslhandling.py\", line 64, in ssl_settings\nE             ssl_check_hostname = ssl_check_hostname is not None or ssl_check_hostname.lower() != 'false'\nE                                                                    ^^^^^^^^^^^^^^^^^^^^^^^^\nE         AttributeError: 'NoneType' object has no attribute 'lower'\n```","shortMessageHtmlLink":"cqlshlib/sslhandling: fix logic of <code>ssl_check_hostname</code>"}},{"before":"601226efbf2495d1edfe8031033fe0f6c1087296","after":"2865af0db58f35d600bb574f91ce63fb2e614183","ref":"refs/heads/add_unix_socket_handling","pushedAt":"2024-01-17T16:00:00.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"Make cqlsh work with unix domain sockets\n\nIn order to use WhiteListRoundRobinPolicy we have to wrap\nhostname in UnixSocketEndPoint.\nThis commit adds checking if hostname is a socket, and if so,\nit adds wrapping hostname into UnixSocketEndPoint.","shortMessageHtmlLink":"Make cqlsh work with unix domain sockets"}},{"before":null,"after":"601226efbf2495d1edfe8031033fe0f6c1087296","ref":"refs/heads/add_unix_socket_handling","pushedAt":"2024-01-15T18:15:57.000Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"Make cqlsh work with unix domain sockets\n\nIn order to use WhiteListRoundRobinPolicy we have to wrap\nhostname in UnixSocketEndPoint.\nThis commit adds checking if hostname is a socket, and if so,\nit adds wrapping hostname into UnixSocketEndPoint.","shortMessageHtmlLink":"Make cqlsh work with unix domain sockets"}},{"before":"8769c4c25b979858829fc0e49c6af7c9fc6720ae","after":"8bd3367e9a77d587a061975df96ac4dccee9683c","ref":"refs/heads/master","pushedAt":"2024-01-15T18:05:28.000Z","pushType":"push","commitsCount":26,"pusher":{"login":"sylwiaszunejko","name":"Sylwia Szunejko","path":"/sylwiaszunejko","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/52855732?s=80&v=4"},"commit":{"message":"dist/debian: add trailer line\n\nthis should address the warnings from dpkg-source and\ndpkg-parsechangelog, like:\n\n```\ndpkg-source: warning: scylla-package/debian/changelog(l3): found end of file where expected more change data or trailer\n```\n\n```\ndpkg-parsechangelog: warning:     debian/changelog(l3): found end of file where expected more change data or trailer\n```\n\nSigned-off-by: Kefu Chai <kefu.chai@scylladb.com>","shortMessageHtmlLink":"dist/debian: add trailer line"}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAEVLorpAA","startCursor":null,"endCursor":null}},"title":"Activity · sylwiaszunejko/scylla-cqlsh"}