Skip to content

Commit 785ea83

Browse files
esnibleistio-testing
authored andcommitted
Be precise about 'workload' vs 'workload instance' (istio#876)
1 parent 87afa02 commit 785ea83

14 files changed

+96
-96
lines changed

authentication/v1alpha1/istio.authentication.v1alpha1.pb.html

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

authentication/v1alpha1/policy.pb.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

authentication/v1alpha1/policy.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -374,10 +374,10 @@ message TargetSelector {
374374
// $hide_from_docs
375375
// $not-implemented-hide
376376
// Select workload by labels.
377-
// Once implemented, this is a prefer way over using service name.
377+
// Once implemented, this is the preferred way rather than using the service name.
378378
map<string, string> labels = 3;
379379

380-
// Specifies the ports. Note that this is the port(s) exposed by the service, not workload ports.
380+
// Specifies the ports. Note that this is the port(s) exposed by the service, not workload instance ports.
381381
// For example, if a service is defined as below, then `8000` should be used, not `9000`.
382382
// ```yaml
383383
// kind: Service

networking/v1alpha3/gateway.pb.go

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/gateway.pb.html

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/gateway.proto

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ message Gateway {
201201
// on which this gateway configuration should be applied. The scope of
202202
// label search is restricted to the configuration namespace in which the
203203
// the resource is present. In other words, the Gateway resource must
204-
// reside in the same namespace as the gateway workload.
204+
// reside in the same namespace as the gateway workload instance.
205205
map<string, string> selector = 2;
206206
}
207207

@@ -362,7 +362,7 @@ message Server {
362362
// as Kubernetes secrets, will be configured to retrieve the
363363
// serverCertificate and the privateKey using credentialName, instead
364364
// of using the file system paths specified above. If using mutual TLS,
365-
// gateway workloads will retrieve the CaCertificates using
365+
// gateway workload instances will retrieve the CaCertificates using
366366
// credentialName-cacert. The semantics of the name are platform
367367
// dependent. In Kubernetes, the default Istio supplied credential
368368
// server expects the credentialName to match the name of the

networking/v1alpha3/service_entry.pb.go

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/service_entry.pb.html

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

networking/v1alpha3/service_entry.proto

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -503,7 +503,7 @@ message ServiceEntry {
503503
// "." or "*" (i.e., the current namespace or all namespaces).
504504
repeated string export_to = 7;
505505

506-
// The list of subject alternate names allowed for workloads that
506+
// The list of subject alternate names allowed for workload instances that
507507
// implement this service. This information is used to enforce
508508
// [secure-naming](/docs/concepts/security/#secure-naming).
509509
// If specified, the proxy will verify that the server

networking/v1alpha3/sidecar.pb.go

Lines changed: 22 additions & 22 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)