Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improvements for reading numeric ID #6278

Open
4 tasks
knelli2 opened this issue Sep 6, 2024 · 0 comments
Open
4 tasks

Improvements for reading numeric ID #6278

knelli2 opened this issue Sep 6, 2024 · 0 comments

Comments

@knelli2
Copy link
Contributor

knelli2 commented Sep 6, 2024

This is specifically for the BBH, but will probably be useful for other systems as well.

  • Allow the ability to choose whether to set $\Pi$ and $\Phi$ from constraints or not. This will be needed for PB&J eventually and potentially also continuing to ringdown
  • Related to the above feature (maybe even part of it), relax restriction that all GH vars must be in the volume data. E.g. if we are specifying Pi and Phi from constraints, we should be able to put Pi: None and Phi: None since we don't need them and this won't cause an error.
  • Add an ObservationTimeEpsilon so users don't have to specify the full precision time of volume data. This is needed elsewhere as well so maybe a general H5/volume subfile solution would be good. (Add epsilon when reading NumericInitialData #6296 )
  • Add ability to check that the domain on disk has identical h-refinement to domain in input file to allow interpolation within elements rather than across elements (important for PB&J).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant