You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While working with CCM, I've been burned a couple times now by self-start not completing properly. There is nothing wrong with the self start code itself. However, if there is a deadlock in the StepActions, then because of quiescence detection, the self-start phase will finish (without error) and the algorithm continues to the evolution with incorrect time stepper history. This can cause all sorts of problems in the evolution and make things hard to debug.
This PR adds a new action that does some consistency/sanity checks on the history data so as to avoid this. Because quiescence can sometimes happen during self start (which we don't want), we can't put this action in the self-start phase itself because the action won't get run. We also don't want to put this in the Evolve phase because this check only needs to be done once. So I added a new phase CheckTimeStepperHistory that goes between self-start and evolve to do these checks.
For lack of time this PR stalled, but it would be nice to revisit.
The text was updated successfully, but these errors were encountered:
@knelli2 wrote in #4690:
For lack of time this PR stalled, but it would be nice to revisit.
The text was updated successfully, but these errors were encountered: