Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[component]: App store badge #3422

Open
6 of 7 tasks
Cian77 opened this issue Aug 20, 2024 · 1 comment · May be fixed by #3731
Open
6 of 7 tasks

[component]: App store badge #3422

Cian77 opened this issue Aug 20, 2024 · 1 comment · May be fixed by #3731
Assignees
@alionazherdetska
Labels
❇️ good first issue Good for newcomers 📦 styles Related to the @swisspost/design-system-styles package
Milestone
PPNL Components

Comments

@Cian77
Copy link

Cian77 commented Aug 20, 2024 •
edited by alionazherdetska
Loading

Description

Create a CSS component for an app store badge.

Proposed markup

<a href="https://link-to-your.app" class="app-store-badge">
  <img src="/local-assets/google.png" alt="" />
  Download the Post App on Google Play
</a>
  • Size of the image should be defined
  • Projects need to provide the app store badge locally (because of localization and requirement to keep the badge up to date)
  • A descriptive text should be provided for the link

Open issues:

Design:

  • Integrated new typography
  • Spacing is defined
  • Documentation final

Tokens:

  • Typography tokens ready

No response

Design

https://www.figma.com/design/JIT5AdGYqv6bDRpfBPV8XR/Foundations-%26-Components-Next-Level?node-id=1530-32646

Tokens

  • Tokens for this component are ready

Tasks

💻 Tasks
Beta Give feedback
@Cian77 Cian77 added the 📦 components Related to the @swisspost/design-system-components package label Aug 20, 2024
@Cian77 Cian77 added this to the Design v2 milestone Aug 20, 2024
@gfellerph gfellerph self-assigned this Aug 28, 2024
@gfellerph gfellerph added 📦 styles Related to the @swisspost/design-system-styles package and removed needs: refinement 📦 components Related to the @swisspost/design-system-components package labels Aug 28, 2024
@gfellerph gfellerph removed their assignment Aug 28, 2024
@gfellerph gfellerph added the ❇️ good first issue Good for newcomers label Aug 28, 2024
@alionazherdetska alionazherdetska self-assigned this Oct 1, 2024
@gfellerph gfellerph modified the milestones: Design v2, Cargo Components Oct 1, 2024
@Vandapanda
Copy link
Contributor

Vandapanda commented Oct 2, 2024 •
edited
Loading

@alionazherdetska You can find the tokens now under Components/App store badge. There is no border radius for focus as its set to 6 right now while the normal component has 4. I assume it will just be handled like everything else and get the border radius from the component itself, if anything changes I'll message you

@alionazherdetska alionazherdetska linked a pull request Oct 11, 2024 that will close this issue
feat(components): create app store badge component(#3422) #3731
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alionazherdetska alionazherdetska

Labels
❇️ good first issue Good for newcomers 📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Status: 🤬 Dev in review
Milestone
PPNL Components
4 participants
@gfellerph @Cian77 @alionazherdetska @Vandapanda