Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[foundations]: Grid #3276

Open
3 of 6 tasks
Cian77 opened this issue Jul 16, 2024 · 3 comments · May be fixed by #3660
Open
3 of 6 tasks

[foundations]: Grid #3276

Cian77 opened this issue Jul 16, 2024 · 3 comments · May be fixed by #3660
Assignees
@alizedebray
Labels
📦 styles Related to the @swisspost/design-system-styles package
Milestone
PPNL Components

Comments

@Cian77
Copy link

Cian77 commented Jul 16, 2024 •
edited by alizedebray
Loading

Description

Open issues:

Tokens:

  • Grid

Design

https://www.figma.com/design/JIT5AdGYqv6bDRpfBPV8XR/Foundations-%26-Components-Next-Level?node-id=26-51

Tokens

  • Tokens for this component are ready

Tasks

💻 Tasks
Beta Give feedback
@Cian77 Cian77 added the 📦 components Related to the @swisspost/design-system-components package label Jul 16, 2024
@Cian77 Cian77 added this to the Components v2 milestone Jul 16, 2024
@gfellerph gfellerph added 📦 styles Related to the @swisspost/design-system-styles package needs: refinement and removed 📦 components Related to the @swisspost/design-system-components package labels Jul 22, 2024
@gfellerph
Copy link
Member

gfellerph commented Jul 22, 2024 •
edited
Loading

Should we copy over the bootstrap grid and use tokens to override the bootstrap vars? Should we do a custom implementation that is close enough to bootstrap for minimal breaking changes?

  • Could be challenging to merge the bootstrap styles/mixins with tokens
  • Copy bootstrap grid into codebase would be the best approach
  • Mobile uses only 6 columns
  • There are 5 breakpoints instead of 3

@gfellerph gfellerph changed the title Grid: [component]: Grid Jul 22, 2024
@Cian77 Cian77 changed the title [component]: Grid [foundations]: Grid Aug 26, 2024
@gfellerph
Copy link
Member

As discussed today, implement breakpoints component tokens that have separate breakpoints for grid (XS, SM, MD, LG, XL) and components (Mobile, Tablet, Desktop).

@alizedebray alizedebray self-assigned this Sep 19, 2024
@gfellerph gfellerph modified the milestones: Design v2, Cargo Components Oct 1, 2024
@alizedebray
Copy link
Contributor

New resolution: https://github.com/orgs/swisspost/projects/3/views/47?pane=issue&itemId=81612717

@alizedebray alizedebray linked a pull request Oct 7, 2024 that will close this issue
feat(styles): build the grid with tokens #3660
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alizedebray alizedebray

Labels
📦 styles Related to the @swisspost/design-system-styles package
Projects
Design System Production Board
Status: 🕹️ Coding in progress
Milestone
PPNL Components
Development

Successfully merging a pull request may close this issue.

feat(styles): build the grid with tokens swisspost/design-system
3 participants
@gfellerph @alizedebray @Cian77