Attribute_optionField error

[intotheweb101]

Hello

I have just found a error that on IE8 it returns an error on line 47 char 10 on file Attribue_OptionField.js.

What is happening is it returns a blank dropdown field for the second option field. The top one works fine. It is just the data on drop down 2 that isn't working.

Any help would be greatly appreciated

Thanks

Hadlee

[intotheweb101]

Hello

I have found a fix.

If you remove this code here from line 47-49 on Attribute_OptionField.js:

if (variationOptions.filter(function(elem) {
    return partial.indexOf(elem) > -1;
}).length == partial.length) {

Into this

if (variationOptions.length == partial.length) {

This may not be the correct fix but it haas been a temporary fix for me

Thanks Hadlee

[frankmullenger]

Thanks @hadlee, I suspect IE8 is missing some functions like filter() and indexOf(). I can't remember but I think there was probably a valid reason why the code was not simply comparing .length - perhaps to take care of an edge case issue. It might be easier if you use a shim (e.g: https://github.com/es-shims/es5-shim) rather than patching this?

[silverstripe-elliot]

.filter() is implemented in jQuery, and I think there's a differently named equivalent for .indexOf(). You could also load the Underscore JS library to accomplish both

[elkebe]

this is also happening on Safari, using Silverstripe 3.6.1... would be great if this was fixed.
Using above workaround @intotheweb101 works, but doesn't reflect any variations to price - this may or may not be related?