You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Every dynamic JS function calls can throw an exception, but the current JSObject and JSFunction are non-throws by default.
They can be throws by .throws or .throwing but it's still opt-in.
For example, if an exception is thrown during a JS function call but the call site in Swift side is not throws, the control unwinding wasm call frames without executing function epilogues even if there is do { } catch {} clause in Swift. And also in that case, defer blocks won't be called.
This behavior is quite tricky and unwinding wasm call frames without executing function epilogues can lead to memory and resource leak.
I'm going to introduce an API breaking change to make JSObject / JSFunction calls be throws in the next next release to improve the situation.
This change has a performance tradeoff as throws variants are typically a little bit slower than non-throwing variants. We should measure the amount of the penalty but it shouldn't be a big deal. We can make non throwing calls as an opt-in feature so that those who want best performance can satisfy their needs.
// Before
letfoo=JSObject.global.document.getElementById!("foo")letfoo=tryJSObject.global.document.throwing.getElementById!("foo")
// After
letfoo=tryJSObject.global.document.getElementById!("foo")letfoo=JSObject.global.document.nonthrowing.getElementById!("foo")
Let me know here if you have a strong objection 🙏 Thanks.
The text was updated successfully, but these errors were encountered:
kateinoigakukun
changed the title
Make JSObject / JSFunction calls be throws
Ask for Feedback: Make JSObject / JSFunction calls be throwsNov 25, 2024
Every dynamic JS function calls can throw an exception, but the current
JSObject
andJSFunction
are non-throws by default.They can be throws by
.throws
or.throwing
but it's still opt-in.For example, if an exception is thrown during a JS function call but the call site in Swift side is not throws, the control unwinding wasm call frames without executing function epilogues even if there is
do { } catch {}
clause in Swift. And also in that case,defer
blocks won't be called.This behavior is quite tricky and unwinding wasm call frames without executing function epilogues can lead to memory and resource leak.
I'm going to introduce an API breaking change to make
JSObject
/JSFunction
calls bethrows
in the next next release to improve the situation.This change has a performance tradeoff as
throws
variants are typically a little bit slower than non-throwing variants. We should measure the amount of the penalty but it shouldn't be a big deal. We can make non throwing calls as an opt-in feature so that those who want best performance can satisfy their needs.Let me know here if you have a strong objection 🙏 Thanks.
The text was updated successfully, but these errors were encountered: