BridgeJS: support imports of JS Promise as async Swift (#707)

* BridgeJS: support imports of `Promise` JS as `async` Swift

* E2e testing of bridging Promise<interface> returns

* fix formatting

* `JSTypedClosure`-based approach

* Clean up `BridgeJSLink`

* Fix missing `import _Concurrency`

* Fix formatting

* Use `JSTypedClosure` without wrapping the result value

* Make closure parameters as `sending`

* Check more stack ABI types

* Add support for `async` in `@JSFunction`

* Use namespaced import

* Fix missing `fetchWeatherData`

* Bring back `fetchWeatherData`

* Regenerate `fetchWeatherData` bridging code

* BridgeJS: Centralize closure sig collection in BridgeSkeletonWalker

* BridgeJS: Stop spreading isAsync handling outside of CallJSEmission

* BridgeJS: Remove error-prone default effects in thunk generation

* BridgeJSLink: Centralize async handling in ImportedThunkBuilder

* BridgeJS: Remove reundant returnType from `call` family of methods in ImportedThunkBuilder

---------

Co-authored-by: Yuta Saito <yuta@goodnotes.com>

Author: MaxDesiatov

Benchmarks/Sources/Generated/JavaScript/BridgeJS.json

@@ -2839,6 +2839,11 @@
       {
         "functions" : [
           {
+            "effects" : {
+              "isAsync" : false,
+              "isStatic" : false,
+              "isThrows" : true
+            },
             "name" : "benchmarkHelperNoop",
             "parameters" : [
 
@@ -2850,6 +2855,11 @@
             }
           },
           {
+            "effects" : {
+              "isAsync" : false,
+              "isStatic" : false,
+              "isThrows" : true
+            },
             "name" : "benchmarkHelperNoopWithNumber",
             "parameters" : [
               {
@@ -2868,6 +2878,11 @@
             }
           },
           {
+            "effects" : {
+              "isAsync" : false,
+              "isStatic" : false,
+              "isThrows" : true
+            },
             "name" : "benchmarkRunner",
             "parameters" : [
               {

Examples/PlayBridgeJS/Sources/PlayBridgeJS/Generated/JavaScript/BridgeJS.json

@@ -242,6 +242,11 @@
       {
         "functions" : [
           {
+            "effects" : {
+              "isAsync" : false,
+              "isStatic" : false,
+              "isThrows" : true
+            },
             "name" : "createTS2Swift",
             "parameters" : [
 
@@ -260,6 +265,11 @@
             ],
             "methods" : [
               {
+                "effects" : {
+                  "isAsync" : false,
+                  "isStatic" : false,
+                  "isThrows" : true
+                },
                 "name" : "convert",
                 "parameters" : [
                   {

Plugins/BridgeJS/Sources/BridgeJSCore/ClosureCodegen.swift

@@ -12,7 +12,10 @@ public struct ClosureCodegen {
     public init() {}
 
     private func swiftClosureType(for signature: ClosureSignature) -> String {
-        let closureParams = signature.parameters.map { "\($0.closureSwiftType)" }.joined(separator: ", ")
+        let sendingPrefix = signature.sendingParameters ? "sending " : ""
+        let closureParams = signature.parameters.map { "\(sendingPrefix)\($0.closureSwiftType)" }.joined(
+            separator: ", "
+        )
         let swiftEffects = (signature.isAsync ? " async" : "") + (signature.isThrows ? " throws" : "")
         let swiftReturnType = signature.returnType.closureSwiftType
         return "(\(closureParams))\(swiftEffects) -> \(swiftReturnType)"
@@ -29,6 +32,7 @@ public struct ClosureCodegen {
         let builder = try ImportTS.CallJSEmission(
             moduleName: "bjs",
             abiName: externName,
+            effects: Effects(isAsync: signature.isAsync, isThrows: signature.isThrows),
             returnType: signature.returnType,
             context: .exportSwift
         )
@@ -185,11 +189,10 @@ public struct ClosureCodegen {
     }
 
     public func renderSupport(for skeleton: BridgeJSSkeleton) throws -> String? {
-        let collector = ClosureSignatureCollectorVisitor()
-        var walker = BridgeTypeWalker(visitor: collector)
+        let collector = ClosureSignatureCollectorVisitor(moduleName: skeleton.moduleName)
+        var walker = BridgeSkeletonWalker(visitor: collector)
         walker.walk(skeleton)
         let closureSignatures = walker.visitor.signatures
-
         guard !closureSignatures.isEmpty else { return nil }
 
         var decls: [DeclSyntax] = []

Plugins/BridgeJS/Sources/BridgeJSCore/ExportSwift.swift

@@ -1228,6 +1228,7 @@ struct ProtocolCodegen {
             let builder = try ImportTS.CallJSEmission(
                 moduleName: moduleName,
                 abiName: "_extern_\(method.name)",
+                effects: method.effects,
                 returnType: method.returnType,
                 context: .exportSwift
             )
@@ -1327,6 +1328,7 @@ struct ProtocolCodegen {
         let getterBuilder = try ImportTS.CallJSEmission(
             moduleName: moduleName,
             abiName: getterAbiName,
+            effects: Effects(isAsync: false, isThrows: false),
             returnType: property.type,
             context: .exportSwift
         )
@@ -1360,6 +1362,7 @@ struct ProtocolCodegen {
             let setterBuilder = try ImportTS.CallJSEmission(
                 moduleName: moduleName,
                 abiName: setterAbiName,
+                effects: Effects(isAsync: false, isThrows: false),
                 returnType: .void,
                 context: .exportSwift
             )