Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User Customisable App Icon #47

Closed
swiftlysingh opened this issue Oct 6, 2020 · 10 comments
Closed

User Customisable App Icon #47

swiftlysingh opened this issue Oct 6, 2020 · 10 comments
Assignees
Labels
enhancement New feature or request hacktoberfest

Comments

@swiftlysingh
Copy link
Owner

What is your idea/feature:
Give the user to customize their app icons.

Why this is beneficial:
This will give users to customize how they want to see their Dashboard 😉 I am providing some App Icon that users can choose from. You can drop in your recommendation too. Create an option in the About Section (Which will be changed to preference after this is implemented.) where users have the option to customize their app icon.

2 3 4

These are not full-sized app icons. When you start with this issue, I will provide you with a link with full-sized app icons.

@swiftlysingh swiftlysingh added enhancement New feature or request hacktoberfest labels Oct 6, 2020
@rajhraval
Copy link
Contributor

I would like to work on this issue.

@swiftlysingh
Copy link
Owner Author

Sure thing. I am assigning this to you. While you are here, do 🌟 the repo!

@rajhraval
Copy link
Contributor

Can I get the link for full-sized app icons? as mentioned in the description.

@swiftlysingh
Copy link
Owner Author

Sure. I actually forgot about that. I have actually sent you a zip of the App Icons on slack. Can you confirm if it is unzipping properly?

@rajhraval
Copy link
Contributor

Yes, AppIcons Pack has unzipped properly.

@swiftlysingh
Copy link
Owner Author

Hey, @rajhraval1 any updates on the issue?

@rajhraval
Copy link
Contributor

Hi @pushpinderpalsingh, the work is already done. Due to my Mac issues not fixed. I am not able to give a PR.

The working is basically as follows:

  1. About View Controller is now a table view controller which opens other view controllers (Just like the settings app).
  2. Selecting App Icons is shown in a table view controller.

Only thing remaining is fixing a checkmark bug after selecting the icon and closing the app.

@swiftlysingh
Copy link
Owner Author

Ok cool, no issues. @rajhraval1 do you have access to an alternate machine? I am looking for someone to do issue #67 and I believe you wanted to do the redesign.

Also is it also possible to change the LaunchScreen according to the selected App Icon?

@rajhraval
Copy link
Contributor

My Mac will arrive by today. I actually had backed up in another Xcode Project. Hopefully will do a PR in a day or two.

About the launch screen, I need to have a look.

Also I have commented on issue #67 for assignment.

@swiftlysingh
Copy link
Owner Author

No worries. I have assigned issue #67 to you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hacktoberfest
Projects
None yet
Development

No branches or pull requests

2 participants