Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting of Swift_MODULE_DIRECTORY (and probably other directories) inappropriate. #2680

Open
dabrahams opened this issue Jun 11, 2024 · 3 comments

Comments

@dabrahams
Copy link
Contributor

https://github.com/apple/swift-syntax/blob/e072677b26ad9a46b15f59fa2b5d7edf4f808e4f/cmake/modules/AddSwiftHostLibrary.cmake#L69-L71

See this warning, which says that it's incompatible with multi-config generators. It also overrides a decision that should be the prerogative of the top level CMake project and if nothing else should be conditionalized on PROJECT_IS_TOP_LEVEL. But really it shouldn't be set at all. All of these settings artificially group files in a way that can cause builds to succeed even if dependencies have not been properly specified, or fail if properly specified, and if nothing else are likely to break all multi-config generators (which includes Xcode) for the forseeable future.

@ahoppen
Copy link
Member

ahoppen commented Jun 12, 2024

Synced to Apple’s issue tracker as rdar://129632873

@rintaro
Copy link
Member

rintaro commented Jun 18, 2024

I'm not sure I fully understand what you're suggesting here. I understand Swift_MODULE_DIRECTORY doesn't currently support multi config generators. But what is actually you are trying to achieve? Are you trying to build swift-syntax project independently with CMake and Xcode?

@dabrahams
Copy link
Contributor Author

I'm trying to build a project that uses Swift-Syntax as a dependency, with CMake and Xcode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants